From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [gdb/testsuite] Fix missing uint8_t in gdb.fortran/logical.exp
Date: Wed, 11 Mar 2020 13:00:41 +0100 [thread overview]
Message-ID: <657de5cd-5725-a579-6330-37a7b697e38c@suse.de> (raw)
In-Reply-To: <20200311102402.GG3317@embecosm.com>
On 11-03-2020 11:24, Andrew Burgess wrote:
>> [gdb/testsuite] Fix missing uint8_t in gdb.fortran/logical.exp
>>
>> With test-case gdb.fortran/logical.exp, I run into:
>> ...
>> (gdb) PASS: gdb.fortran/logical.exp: var=l: get hexadecimal valueof "&l"
>> set *((uint8_t *) 0x7fffffffd2bc) = 0xff^M
>> No symbol "uint8_t" in current context.^M
>> (gdb) FAIL: gdb.fortran/logical.exp: var=l: byte 0: set contents of byte at offset 0
>> ...
>>
>> Fix this by using the fortran-native type character instead.
>>
>> Tested on x86_64-linux, with gcc 7.5.0 and clang 5.0.2.
>
> I dug into this because, as we discussed on IRC you are seeing
> failures with 7.5, while I am seeing passes with 7.4. For me I was
> getting the symbol from libgfortan. I wonder if it's possible that
> you're linking against an older version of libgfortran, even with a
> newer gcc?
>
Hi Andrew,
Just to confirm:
- I installed all debuginfo packages that my openSUSE system gdb
suggested for the executable, and
- I rebuild gdb with configure flag
--with-separate-debug-dir=/usr/lib/debug
After these two modifications, the test passes for me without the patch.
Thanks,
- Tom
next prev parent reply other threads:[~2020-03-11 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 17:00 [PATCH] gdb/fortran Fixed printing of logical true values for Flang Sharma, Alok Kumar
2020-03-02 18:21 ` [PATCHv2] gdb/fortran: Fix " Andrew Burgess
2020-03-03 4:47 ` Sharma, Alok Kumar
2020-03-03 18:21 ` Andrew Burgess
2020-03-04 8:48 ` [gdb/testsuite] Fix missing uint8_t in gdb.fortran/logical.exp Tom de Vries
2020-03-11 10:24 ` Andrew Burgess
2020-03-11 12:00 ` Tom de Vries [this message]
2020-03-03 16:32 ` [PATCHv2] gdb/fortran: Fix printing of logical true values for Flang Tom Tromey
2020-03-03 17:24 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657de5cd-5725-a579-6330-37a7b697e38c@suse.de \
--to=tdevries@suse.de \
--cc=AlokKumar.Sharma@amd.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).