From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 434233858C39 for ; Wed, 1 Mar 2023 14:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 434233858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74DF01FE12; Wed, 1 Mar 2023 14:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677681287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=45Ye05svcoKpA2LhQ9YPVqSFroeMjh0b4dAr3id6wdA=; b=2WrchQW1r6HRK9OHMNvproU6cfuytSASH1FxgGhBe2+V8b/ugtcjK4KwOxAwF8tuB1werG 9BON/N8NwSvLc9MfSXoEbmOpv8Wrcx0+Ugxt2mY1irkTlv+8zq7ix7CBYQW5pDnu0pkQER hiojnKnVsa2D/fLqtZ9nTKSPth+LQYY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677681287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=45Ye05svcoKpA2LhQ9YPVqSFroeMjh0b4dAr3id6wdA=; b=YDhmAe4kJnJ87dYCVOlSP0cbUuLaqw/pngNHXi2LiSO/N+UqZHSm5YWqw323mdu0LdiJIE L4EK3bCwW7Wk++BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5181213A63; Wed, 1 Mar 2023 14:34:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qjyoEodi/2N0PQAAMHmgww (envelope-from ); Wed, 01 Mar 2023 14:34:47 +0000 Content-Type: multipart/mixed; boundary="------------lgpWaflB64mb8s8Ay8zFtmcM" Message-ID: <65861786-069e-53a1-ca17-a525b6629c95@suse.de> Date: Wed, 1 Mar 2023 15:34:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH ] PowerPC: fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp Content-Language: en-US To: Carl Love , Ulrich Weigand , "gdb-patches@sourceware.org" , Bruno Larsen , "pedro@palves.net" References: <78b464a1-e32e-c3da-85e4-7bfc322cc29f@redhat.com> <7848e9858b54e33e399b871774ffc0b5058c1736.camel@us.ibm.com> <65d44121-65f7-a212-79ec-07ce53c15ecb@suse.de> <9fe94c0979cb40979b0dea7693a901c2d9f66164.camel@us.ibm.com> <59417813-eb4a-baf8-4e5d-e225d6732f71@suse.de> <7a494157-494f-6adf-d533-bf373b0f054f@redhat.com> <71aa635593df0677811afb85409aa190bcfa4f6a.camel@us.ibm.com> <15864a6b87b25c93e99a28149f23138267735f2a.camel@us.ibm.com> <041f62e9f26fd4a536bc90c34f072985582e6237.camel@de.ibm.com> <46c2c756475ba5923d7eed97996632a08285dd42.camel@us.ibm.com> From: Tom de Vries In-Reply-To: <46c2c756475ba5923d7eed97996632a08285dd42.camel@us.ibm.com> X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------lgpWaflB64mb8s8Ay8zFtmcM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/20/23 21:24, Carl Love wrote: > .../gdb.reverse/step-indirect-call-thunk.exp | 55 ++--- > gdb/testsuite/lib/gdb.exp | 49 +++- I think the changes in these two files are not really related to $subject. The only connection is that the newly introduced test-case gdb.reverse/finish-reverse-next.exp uses repeat_cmd_until. I propose to commit attached patch separately. Carl, can you review the commit message? Thanks, - Tom --------------lgpWaflB64mb8s8Ay8zFtmcM Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Introduce-repeat_cmd_until.patch" Content-Disposition: attachment; filename="0001-gdb-testsuite-Introduce-repeat_cmd_until.patch" Content-Transfer-Encoding: base64 RnJvbSBkMjExYjRkMTdjNGMyMjUzZDg1YTczYTc4ZGI1NTgxYjM2OTc0NmJkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDYXJsIExvdmUgPGNlbEB1cy5pYm0uY29tPgpEYXRl OiBXZWQsIDEgTWFyIDIwMjMgMTQ6NTA6MTUgKzAxMDAKU3ViamVjdDogW1BBVENIXSBbZ2Ri L3Rlc3RzdWl0ZV0gSW50cm9kdWNlIHJlcGVhdF9jbWRfdW50aWwKClRlc3QtY2FzZSBnZGIu cmV2ZXJzZS9zdGVwLWluZGlyZWN0LWNhbGwtdGh1bmsuZXhwIGNvbnRhaW5zIGEgcHJvYyBz dGVwX3VudGlsLgoKT1RPSCwgd2UndmUgZ290IGEgc29tZXdoYXQgc2ltaWxhciBwcm9jIGlu IGxpYi9nZGIuZXhwOiBnZGJfc3RlcF91bnRpbC4KCkZpeCB0aGlzIGJ5OgotIG1vdmluZyBz dGVwX3VudGlsIGludG8gbGliL2dkYi5leHAgYW5kIHJlbmFtaW5nIHRvIHJlcGVhdF9jbWRf dW50aWwsCi0gcmVpbXBsZW1lbnRpbmcgZ2RiX3N0ZXBfdW50aWwgdXNpbmcgcmVwZWF0X2Nt ZF91bnRpbCwgYW5kCi0gcmVpbXBsZW1lbnRpbmcgc3RlcF91bnRpbCBhcyBhbiBsb2NhbCBh bGlhcyBvZiByZXBlYXRfY21kX3VudGlsCiAgKGluIG9yZGVyIHRvIGF2b2lkIHBvbGx1dGlu ZyBoaXN0b3J5IHdpdGggdXBkYXRpbmcgYWxsIHRoZSBjYWxscykuCgpUZXN0ZWQgb24geDg2 XzY0LWxpbnV4LgotLS0KIC4uLi9nZGIucmV2ZXJzZS9zdGVwLWluZGlyZWN0LWNhbGwtdGh1 bmsuZXhwICB8IDMyICstLS0tLS0tLS0tLQogZ2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cCAg ICAgICAgICAgICAgICAgICAgIHwgNDkgKysrKysrKysrKysrKystLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCA0MSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9nZGIvdGVzdHN1aXRlL2dkYi5yZXZlcnNlL3N0ZXAtaW5kaXJlY3QtY2FsbC10aHVuay5l eHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5yZXZlcnNlL3N0ZXAtaW5kaXJlY3QtY2FsbC10aHVu ay5leHAKaW5kZXggZjQzM2VmYjExYzIuLmQ0MzFkMTc0Zjg4IDEwMDY0NAotLS0gYS9nZGIv dGVzdHN1aXRlL2dkYi5yZXZlcnNlL3N0ZXAtaW5kaXJlY3QtY2FsbC10aHVuay5leHAKKysr IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucmV2ZXJzZS9zdGVwLWluZGlyZWN0LWNhbGwtdGh1bmsu ZXhwCkBAIC0zOCwzNyArMzgsOSBAQCBpZiB7ICFbcnVudG9fbWFpbl0gfSB7CiAgICAgcmV0 dXJuIC0xCiB9CiAKLSMgRG8gcmVwZWF0ZWQgc3RlcHBpbmcgQ09NTUFORHMgaW4gb3JkZXIg dG8gcmVhY2ggVEFSR0VUIGZyb20gQ1VSUkVOVAotIwotIyAgQ09NTUFORCBpcyBhIHN0ZXBw aW5nIGNvbW1hbmQKLSMgIENVUlJFTlQgaXMgYSBzdHJpbmcgbWF0Y2hpbmcgdGhlIGN1cnJl bnQgbG9jYXRpb24KLSMgIFRBUkdFVCAgaXMgYSBzdHJpbmcgbWF0Y2hpbmcgdGhlIHRhcmdl dCBsb2NhdGlvbgotIyAgVEVTVCAgICBpcyB0aGUgdGVzdCBuYW1lCi0jCi0jIFRoZSBmdW5j dGlvbiBpc3N1ZXMgcmVwZWF0ZWQgQ09NTUFORHMgYXMgbG9uZyBhcyB0aGUgbG9jYXRpb24g bWF0Y2hlcwotIyBDVVJSRU5UIHVwIHRvIGEgbWF4aW11bSBvZiAxMDAgc3RlcHMuCi0jCi0j IFRFU1QgcGFzc2VzIGlmIHRoZSByZXN1bHRpbmcgbG9jYXRpb24gbWF0Y2hlcyBUQVJHRVQg YW5kIGZhaWxzCi0jIG90aGVyd2lzZS4KLSMKKyMgTG9jYWwgYWxpYXMgZm9yIHJlcGVhdF9j bWRfdW50aWwuCiBwcm9jIHN0ZXBfdW50aWwgeyBjb21tYW5kIGN1cnJlbnQgdGFyZ2V0IHRl c3QgfSB7Ci0gICAgZ2xvYmFsIGdkYl9wcm9tcHQKLQotICAgIHNldCBjb3VudCAwCi0gICAg Z2RiX3Rlc3RfbXVsdGlwbGUgIiRjb21tYW5kIiAiJHRlc3QiIHsKLSAgICAgICAgLXJlICIk Y3VycmVudC4qJGdkYl9wcm9tcHQgJCIgewotICAgICAgICAgICAgaW5jciBjb3VudAotICAg ICAgICAgICAgaWYgeyAkY291bnQgPCAxMDAgfSB7Ci0gICAgICAgICAgICAgICAgc2VuZF9n ZGIgIiRjb21tYW5kXG4iCi0gICAgICAgICAgICAgICAgZXhwX2NvbnRpbnVlCi0gICAgICAg ICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIGZhaWwgIiR0ZXN0IgotICAgICAgICAg ICAgfQotICAgICAgICB9Ci0gICAgICAgIC1yZSAiJHRhcmdldC4qJGdkYl9wcm9tcHQgJCIg ewotICAgICAgICAgICAgcGFzcyAiJHRlc3QiCi0gICAgICAgIH0KLSAgICB9CisgICAgcmVw ZWF0X2NtZF91bnRpbCAkY29tbWFuZCAkY3VycmVudCAkdGFyZ2V0ICR0ZXN0CiB9CiAKIGdk Yl90ZXN0X25vX291dHB1dCAicmVjb3JkIgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9s aWIvZ2RiLmV4cCBiL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAKaW5kZXggMTljNzgyYmVh NDYuLjY1MGE0NGFhYjFlIDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2xpYi9nZGIuZXhw CisrKyBiL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAKQEAgLTkyNzAsMzEgKzkyNzAsNTgg QEAgZ2RiX2NhY2hpbmdfcHJvYyBhcm1fY2NfZm9yX3RhcmdldCB7CiAKICMgU3RlcCB1bnRp bCB0aGUgcGF0dGVybiBSRUdFWFAgaXMgZm91bmQuICBTdGVwIGF0IG1vc3QKICMgTUFYX1NU RVBTIHRpbWVzLCBidXQgc3RvcCBzdGVwcGluZyBvbmNlIFJFR0VYUCBpcyBmb3VuZC4KLSMK KyMgQ1VSUkVOVCBtYXRjaGVzIGN1cnJlbnQgbG9jYXRpb24uCiAjIElmIFJFR0VYUCBpcyBm b3VuZCB0aGVuIGEgc2luZ2xlIHBhc3MgaXMgZW1pdHRlZCwgb3RoZXJ3aXNlLCBhZnRlcgog IyBNQVhfU1RFUFMgc3RlcHMsIGEgc2luZ2xlIGZhaWwgaXMgZW1pdHRlZC4KICMKICMgVEVT VF9OQU1FIGlzIHRoZSBuYW1lIHVzZWQgaW4gdGhlIHBhc3MvZmFpbCBjYWxscy4KIAotcHJv YyBnZGJfc3RlcF91bnRpbCB7IHJlZ2V4cCB7dGVzdF9uYW1lICIifSB7bWF4X3N0ZXBzIDEw fSB9IHsKK3Byb2MgZ2RiX3N0ZXBfdW50aWwgeyByZWdleHAge3Rlc3RfbmFtZSAiIn0ge2N1 cnJlbnQgIiJ9IFwKKwkJCSAgeyBtYXhfc3RlcHMgMTAgfSB9IHsKKyAgICBpZiB7ICRjdXJy ZW50ID09ICIiIH0geworCXNldCBjdXJyZW50ICJcfSIKKyAgICB9CisgICAgaWYgeyAkdGVz dF9uYW1lID09ICIiIH0geworCXNldCB0ZXN0X25hbWUgInN0ZXBwaW5nIHVudGlsIHJlZ2V4 cCIKKyAgICB9CisKKyAgICByZXBlYXRfY21kX3VudGlsICJzdGVwIiAkY3VycmVudCAgJHJl Z2V4cCAgJHRlc3RfbmFtZSAiMTAiCit9CisKKyMgRG8gcmVwZWF0ZWQgc3RlcHBpbmcgQ09N TUFORHMgaW4gb3JkZXIgdG8gcmVhY2ggVEFSR0VUIGZyb20gQ1VSUkVOVAorIworIyAgQ09N TUFORCBpcyBhIHN0ZXBwaW5nIGNvbW1hbmQKKyMgIENVUlJFTlQgaXMgYSBzdHJpbmcgbWF0 Y2hpbmcgdGhlIGN1cnJlbnQgbG9jYXRpb24KKyMgIFRBUkdFVCAgaXMgYSBzdHJpbmcgbWF0 Y2hpbmcgdGhlIHRhcmdldCBsb2NhdGlvbgorIyAgVEVTVCAgICBpcyB0aGUgdGVzdCBuYW1l CisjICBNQVhfU1RFUFMgaXMgbnVtYmVyIG9mIHN0ZXBzIGF0dGVtcHRlZCBiZWZvcmUgZmFp bCBpcyBlbWl0dGVkCisjCisjIFRoZSBmdW5jdGlvbiBpc3N1ZXMgcmVwZWF0ZWQgQ09NTUFO RHMgYXMgbG9uZyBhcyB0aGUgbG9jYXRpb24gbWF0Y2hlcworIyBDVVJSRU5UIHVwIHRvIGEg bWF4aW11bSBvZiAxMDAgc3RlcHMuCisjCisjIFRFU1QgcGFzc2VzIGlmIHRoZSByZXN1bHRp bmcgbG9jYXRpb24gbWF0Y2hlcyBUQVJHRVQgYW5kIGZhaWxzCisjIG90aGVyd2lzZS4KKyMK K3Byb2MgcmVwZWF0X2NtZF91bnRpbCB7IGNvbW1hbmQgY3VycmVudCB0YXJnZXQgdGVzdF9u YW1lIHttYXhfc3RlcHMgMTAwfSB9IHsKKyAgICBnbG9iYWwgZ2RiX3Byb21wdAogICAgIGlm IHsgJHRlc3RfbmFtZSA9PSAiIiB9IHsKIAlzZXQgdGVzdF9uYW1lICJzdGVwcGluZyB1bnRp bCByZWdleHAiCiAgICAgfQogCiAgICAgc2V0IGNvdW50IDAKLSAgICBnZGJfdGVzdF9tdWx0 aXBsZSAic3RlcCIgIiR0ZXN0X25hbWUiIHsKLQktcmUgIiRyZWdleHBcclxuJDo6Z2RiX3By b21wdCAkIiB7Ci0JICAgIHBhc3MgJHRlc3RfbmFtZQotCX0KLQktcmUgIi4qJDo6Z2RiX3By b21wdCAkIiB7Ci0JICAgIGlmIHskY291bnQgPCAkbWF4X3N0ZXBzfSB7Ci0JCWluY3IgY291 bnQKLQkJc2VuZF9nZGIgInN0ZXBcbiIKKyAgICBnZGJfdGVzdF9tdWx0aXBsZSAiJGNvbW1h bmQiICIkdGVzdF9uYW1lIiB7CisJLXJlICIkY3VycmVudC4qJGdkYl9wcm9tcHQgJCIgewor CSAgICBpbmNyIGNvdW50CisJICAgIGlmIHsgJGNvdW50IDwgJG1heF9zdGVwcyB9IHsKKwkJ c2VuZF9nZGIgIiRjb21tYW5kXG4iCiAJCWV4cF9jb250aW51ZQogCSAgICB9IGVsc2Ugewot CQlmYWlsICR0ZXN0X25hbWUKKwkJZmFpbCAiJHRlc3RfbmFtZSIKIAkgICAgfQogCX0KKwkt cmUgIiR0YXJnZXQuKiRnZGJfcHJvbXB0ICQiIHsKKwkgICAgcGFzcyAiJHRlc3RfbmFtZSIK Kwl9CiAgICAgfQogfQogCgpiYXNlLWNvbW1pdDogMmMyOWIxZWQxOTcxMWZhMmExNjU1ODAx NWU1YTZiNDZhMDlhZWZlYgotLSAKMi4zNS4zCgo= --------------lgpWaflB64mb8s8Ay8zFtmcM--