public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "周春明(日月)" <riyue.zcm@alibaba-inc.com>
To: "Gdb-patches"
	<gdb-patches-bounces+riyue.zcm=alibaba-inc.com@sourceware.org>,
	 "Simon Marchi" <simon.marchi@polymtl.ca>,
	"gdb-patches" <gdb-patches@sourceware.org>
Cc: "Louis-He" <1726110778@qq.com>,
	"Dominique Quatravaux" <dominique.quatravaux@epfl.ch>,
	"Sam Warner" <samuel.r.warner@me.com>
Subject: ../../gdbsupport/new-op.cc:137:1: error: ‘void operator delete [](void*, std::size_t)’ is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
Date: Tue, 01 Mar 2022 15:48:47 +0800	[thread overview]
Message-ID: <65ee9ce9-34db-4434-9cc6-34378f96bee9.riyue.zcm@alibaba-inc.com> (raw)


Hi GDB maintainers,

I tried to build new GDB12, but encounter below error, anyone could tell me how to fix it? Thanks!

 CXX new-op.o
../../gdbsupport/new-op.cc:32:13: error: ‘void operator delete(void*, std::size_t)’ is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
 extern void operator delete (void *p, std::size_t) noexcept;
 ^
../../gdbsupport/new-op.cc:33:13: error: ‘void operator delete [](void*, std::size_t)’ is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
 extern void operator delete[] (void *p, std::size_t) noexcept;
 ^
../../gdbsupport/new-op.cc:119:1: error: ‘void operator delete(void*, std::size_t)’ is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
 operator delete (void *p, std::size_t) noexcept
 ^
../../gdbsupport/new-op.cc:137:1: error: ‘void operator delete [](void*, std::size_t)’ is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
 operator delete[] (void *p, std::size_t) noexcept

------------------------------------------------------------------
发件人:Philippe Blain via Gdb-patches <gdb-patches@sourceware.org>
发送时间:2022年3月1日(星期二) 02:41
收件人:Simon Marchi <simon.marchi@polymtl.ca>; gdb-patches <gdb-patches@sourceware.org>
抄 送:Louis-He <1726110778@qq.com>; Dominique Quatravaux <dominique.quatravaux@epfl.ch>; Sam Warner <samuel.r.warner@me.com>
主 题:Re: [RFC][PATCH v3 1/1][PR gdb/24069] gdb/darwin: skip over WIFSTOPPED wait4 status



Le 2022-02-28 à 13:34, Simon Marchi a écrit :
> 
> 
> On 2022-02-28 12:52, Philippe Blain wrote:
>> Hi Simon,
>>
>> Le 2022-02-24 à 10:49, Simon Marchi a écrit :
>>>
>>>
>>> On 2022-02-24 09:23, Philippe Blain wrote:
>>>> From: Dominique Quatravaux <dominique.quatravaux@epfl.ch>
>>>>>
>>>>
>>>>  PR gdb/24609
>>>>  * gdb/darwin-nat.c (darwin_nat_target::decode_message): Also
>>>>  check for WIFSTOPPED upon MACH_NOTIFY_DEAD_NAME.
>>>
>>> Thanks, pushed.
>>>
>>> Simon
>>>
>>
>> I noticed that the Bugzilla entry was not updated when you pushed
>> that commit, whereas it was for the previous one [1]. I'm not sure
>> of what is the automation that makes this work...
>>
>> I thought it was because my changelog entry mistakenly used 24609 instead
>> of 24069, but that was the case also for v2 1/2, so I guess that's not
>> the cause...
> 
> Patch #1 had a link to the correct bugzilla ticket in its commit message,
> so the connection was made.
> 
> Patch #2 didn't have any mention of the bugzilla ticket, so there was
> no connection.
> 
> The correct thing to do nowadays, according to our standard procedures,
> would have been to use the:
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24069
> 
> trailer.  But I often forget about it.
> 
> Simon

Noted. I just checked the ContributionChecklist page and
see you've updated it, thanks :)

Philippe.

[1] https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages

             reply	other threads:[~2022-03-01  7:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01  7:48 周春明(日月) [this message]
2022-03-01 14:32 ` Simon Marchi
2022-03-02  3:08   ` 回复:../../gdbsupport/new-op.cc:137:1: " 周春明(日月)
2022-03-02 16:45     ` Simon Marchi
2022-03-02 16:30 ` ../../gdbsupport/new-op.cc:137:1: " Andrew Burgess
2022-03-02 16:54   ` Simon Marchi
2022-03-02 17:03     ` Pedro Alves
2022-03-02 17:26       ` Simon Marchi
2022-03-02 17:43         ` Pedro Alves
2022-03-02 17:22     ` Andrew Burgess
2022-03-02 17:41       ` Simon Marchi
2022-03-03 12:27         ` Andrew Burgess
2022-03-03 14:18         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65ee9ce9-34db-4434-9cc6-34378f96bee9.riyue.zcm@alibaba-inc.com \
    --to=riyue.zcm@alibaba-inc.com \
    --cc=1726110778@qq.com \
    --cc=dominique.quatravaux@epfl.ch \
    --cc=gdb-patches-bounces+riyue.zcm=alibaba-inc.com@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=samuel.r.warner@me.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).