From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8315C3887551 for ; Mon, 30 Mar 2020 15:13:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8315C3887551 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 17EE31E581; Mon, 30 Mar 2020 11:13:37 -0400 (EDT) Subject: Re: [PATCH 07/20] Remove DW_BLOCK To: Tom Tromey , gdb-patches@sourceware.org References: <20200328192208.11324-1-tom@tromey.com> <20200328192208.11324-8-tom@tromey.com> From: Simon Marchi Message-ID: <662fb46e-19df-2927-6892-ba84d01ecd33@simark.ca> Date: Mon, 30 Mar 2020 11:13:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200328192208.11324-8-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 15:13:38 -0000 On 2020-03-28 3:21 p.m., Tom Tromey wrote: > @@ -22578,8 +22578,8 @@ dwarf2_symbol_mark_computed (const struct attribute *attr, struct symbol *sym, > info_buffer for SYM's objfile; right now we never release > that buffer, but when we do clean up properly this may > need to change. */ > - baton->size = DW_BLOCK (attr)->size; > - baton->data = DW_BLOCK (attr)->data; > + baton->size = attr->block ()->size; > + baton->data = attr->block ()->data; Again, in these cases, it would probably be worth using a local variable to store the result of attr->block (), to avoid doing the check twice. Simon