From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74408 invoked by alias); 4 Mar 2020 19:46:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74383 invoked by uid 89); 4 Mar 2020 19:46:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*M:yahoo, H*x:WebService, H*x:Mozilla, H*UA:WebService X-HELO: sonic314-20.consmr.mail.ir2.yahoo.com Received: from sonic314-20.consmr.mail.ir2.yahoo.com (HELO sonic314-20.consmr.mail.ir2.yahoo.com) (77.238.177.146) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Mar 2020 19:46:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1583351206; bh=cYOLlnpZYh+5U3ML9084sUiyi+AJYDxS+omhvk1BxYY=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=R7Kwm6lxbQjOZ01k9Qsh7ymhvJqK5rOdOYI4BpIGTTEKt+BrpyFvrna5kSm3wCxUbzu86xdXBrHQGJiDBUiA4sEJJlwM1L/Hg0Hktp8tUlZh8QNd3CqkN6Joh0HBlVtb23mBZs5w+kv6tVPBR7F8bJ6rqe0EwiohBXqQUJIgVvuPqDycTlSWODsc1Mgk8Ugji/S5o4NFtGlvfjzhKO7Uksvd7qyBkXGTXuvDuMm4ROG/9t053zFbcp+vc3D4nIDZu8pXFpHKoskEdTzVTY+DZi62upS/Gs3o3es3wwTIa7pTVHoIBCiDuvtNPMO8fCRGQTSdOdnC+qE/FtcYIoyUQg== Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Wed, 4 Mar 2020 19:46:46 +0000 Date: Wed, 04 Mar 2020 19:46:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <667267301.7060481.1583351203448@mail.yahoo.com> In-Reply-To: <711a3001-da27-4400-5d11-93ed14e503f2@simark.ca> References: <20200304191632.14947-1-ssbssa.ref@yahoo.de> <20200304191632.14947-1-ssbssa@yahoo.de> <711a3001-da27-4400-5d11-93ed14e503f2@simark.ca> Subject: Re: [PATCH v3] Implement debugging of WOW64 processes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00097.txt Am Mittwoch, 4. M=C3=A4rz 2020, 20:32:52 MEZ hat Simon Marchi Folgendes geschrieben: > On 2020-03-04 2:16 p.m., Hannes Domani via gdb-patches wrote: > > @@ -99,7 +99,5 @@ void _initialize_amd64_windows_nat (); > >=C2=A0 void > >=C2=A0 _initialize_amd64_windows_nat () > >=C2=A0 { > > -=C2=A0 windows_set_context_register_offsets (mappings); > > -=C2=A0 windows_set_segment_register_p (amd64_windows_segment_register_= p); > >=C2=A0=C2=A0=C2=A0 x86_set_debug_register_length (8); > >=C2=A0 } > > Does x86_set_debug_register_length need to be adjusted based on the type = of the > process?=C2=A0 With the current code, it will be set to 8 even if debuggi= ng a WOW64 > process, is that what we want? I don't really know what this is for, but I haven't had any problem so far = like this. Besides, there is this comment in x86-nat.c: void x86_set_debug_register_length (int len) { =C2=A0 /* This function should be called only once for each native target.= =C2=A0 */ =C2=A0 gdb_assert (x86_dr_low.debug_register_length =3D=3D 0); ... Regards Hannes Domani