From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 743413858D35 for ; Thu, 16 Mar 2023 14:57:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 743413858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Pcr2g1T2Rz3MRn; Thu, 16 Mar 2023 14:57:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pcr2g0cg1z3N9G; Thu, 16 Mar 2023 14:57:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678978635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kvy1hCieJyf9S7poucuuSxKZFITBf/Gsj7oA91Hrs8A=; b=icBDm44S/Z5ZPqPlX6IACWPdQsWAtrhm/JwL7UodNFgngD46+l92YEbTG1/CSl7KFdXx2T SRlYERO0uzRuG2viyM3UDfFah9JVd8MLCw79TwHaoipO2RsSrredg5F+r8dpUmrzU44Tkx TLZrf18u4xwTIanBYy79HD8dBRMO5r5Vc9/t1se9912DtGvJP2sGh6/MijOAEUDFRtVlYJ 4zJtvqAJ8xAfi/FVhaH0c/4dTmqn587LORKNx25ZuXvdkgKPYuD5qBe7MTLovsQ+3K7k0H jrN3CuKgcLOxjEBomb1SluMfp9qnGQFBBz0KVUBcaaIQZiigT/76N1cXqp+a6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678978635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kvy1hCieJyf9S7poucuuSxKZFITBf/Gsj7oA91Hrs8A=; b=TFMC43RtjlCUBnji3p8FS+8oTgTdjBUvdSV8uGbZd7O1U26a0SfIhXH1uGz2WspMGP2Jkv FMaDGiVUYRHiFaO1Z1Ut4x7Xq6ODol6rETI1hBl9qSMonxJUcFuqOu6QUz9/2dULG17CDU wqVsIeBNtAiujBbJVdzWbpSLzsB1pWjpXmGRPZm1eVxRVLF5dAv2UsMk1NcVYjvyeKb7Hq KKloI/3aacw2TJj/osLu6sgyvqjb8i6TbKs21l1eZXGyX1c8gICqvK1O6vM6ePsUTuoqSV dMk2RCEfY75kygsg6kZm2a1lyPGgwmpy046ZmBDlic/wcL7gpvLSy1jfOUz9iw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678978635; a=rsa-sha256; cv=none; b=KgQ3wZXkYbf4/kthPSNZPdTFJMwc8LzprOtRv+hp2+CGTujAbYy2DoYvebrGXqgZ4aexF7 axHx6x6iYUfVJKuAucTA//Y6dU0VLrylirhuHRUnOnrD9WYvetujbfKLnyWUNwZ0XdFChd 0n8xHpE4R0JZGXybrRXdQTY1PKuRc2FhZMqXLXXnNBvHL9vi5wqkD9eVRR40QVLtJmlYQv k7r52odbiBd8bNYHpNN5i+uxtIo4hcA7pMRA7Ape9LASu1U50OVQf+hha9Cb0IaeTpLcl3 Ps7KRl8l9tYNr30d44hlDKNGsK5yYXYw0UWOEom+SpnIpSCGYBoXhMzBJivpzw== Received: from [IPV6:2601:648:8680:16b0:8935:95bf:f86b:350e] (unknown [IPv6:2601:648:8680:16b0:8935:95bf:f86b:350e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Pcr2f4bNMzWm7; Thu, 16 Mar 2023 14:57:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <668c672d-29f2-d578-afac-ff2efe1a8915@FreeBSD.org> Date: Thu, 16 Mar 2023 07:57:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Fix build breakage in rs6000-aix-tdep.c Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230316134920.2913561-1-tromey@adacore.com> From: John Baldwin In-Reply-To: <20230316134920.2913561-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/16/23 6:49 AM, Tom Tromey via Gdb-patches wrote: > A recent change to rs6000-aix-tdep.c broke the build. This patch > fixes it by declaring a few target descriptions in ppc-tdep.h and then > not including the various features .c files in rs6000-aix-tdep.c. > --- > gdb/ppc-tdep.h | 6 ++++++ > gdb/rs6000-aix-tdep.c | 5 ----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/gdb/ppc-tdep.h b/gdb/ppc-tdep.h > index fe41baef149..db4e53205a6 100644 > --- a/gdb/ppc-tdep.h > +++ b/gdb/ppc-tdep.h > @@ -450,4 +450,10 @@ struct ppc_inferior_data > > extern ppc_inferior_data * get_ppc_per_inferior (inferior *inf); > > +extern const struct target_desc *tdesc_powerpc_vsx64l; > +extern const struct target_desc *tdesc_powerpc_vsx64; > +extern const struct target_desc *tdesc_powerpc_vsx32; > +extern const struct target_desc *tdesc_powerpc_altivec64; > +extern const struct target_desc *tdesc_powerpc_altivec32; > + > #endif /* ppc-tdep.h */ > diff --git a/gdb/rs6000-aix-tdep.c b/gdb/rs6000-aix-tdep.c > index c56e5a384e4..d4a7b22bc4f 100644 > --- a/gdb/rs6000-aix-tdep.c > +++ b/gdb/rs6000-aix-tdep.c > @@ -40,11 +40,6 @@ > #include "trad-frame.h" > #include "frame-unwind.h" > > -#include "features/rs6000/powerpc-altivec32.c" > -#include "features/rs6000/powerpc-vsx32.c" > -#include "features/rs6000/powerpc-altivec64.c" > -#include "features/rs6000/powerpc-vsx64.c" > - > /* If the kernel has to deliver a signal, it pushes a sigcontext > structure on the stack and then calls the signal handler, passing > the address of the sigcontext in an argument register. Usually LGTM -- John Baldwin