From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CAA6B388B024 for ; Fri, 22 May 2020 20:58:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CAA6B388B024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 35DCE1E5F9; Fri, 22 May 2020 16:58:14 -0400 (EDT) Subject: Re: [PATCH 4/4] gdb: remove TYPE_FIELDS macro To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20200519184441.7838-1-simon.marchi@efficios.com> <20200519184441.7838-4-simon.marchi@efficios.com> <874ks73ei2.fsf@tromey.com> From: Simon Marchi Message-ID: <669518ab-c27e-a487-4421-9a3a5773eae3@simark.ca> Date: Fri, 22 May 2020 16:58:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <874ks73ei2.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 20:58:15 -0000 On 2020-05-22 4:23 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> Remove all uses of the `TYPE_FIELDS` macro. Replace them with either: > Simon> 1) type::fields, to obtain a pointer to the fields array (same as > Simon> TYPE_FIELDS yields) > > Simon> 2) type::field, a new convenience method that obtains a reference to one > Simon> of the type's field by index. It is meant to replace > Simon> TYPE_FIELDS (type)[idx] > > I suppose a future patch will remove the TYPE_FIELD macro? Hmm right, it would have made sense to have a patch for that in this series... too bad, I'll just send it separately. > Simon> - TYPE_FIELDS (type) = (struct field *) > Simon> - TYPE_ZALLOC (type, sizeof (struct field) * count); > Simon> + type->set_fields > Simon> + ((struct field *) TYPE_ZALLOC (type, sizeof (struct field) * count)); > Simon> TYPE_UNSIGNED (type) = 1; > > Technically I suppose this should be in the earlier patch. Hmm yes, otherwise the previous commit wouldn't build. Thanks for checking, I've fixed, made sure that all commits built fine with --enable-targets=all and pushed the series. Simon