From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1111F382CC18 for ; Tue, 17 Aug 2021 13:29:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1111F382CC18 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17HDSqcP009617 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Aug 2021 09:28:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17HDSqcP009617 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8E73D1EA7E; Tue, 17 Aug 2021 09:28:52 -0400 (EDT) Subject: Re: [PATCH 1/3] gdb/solib: Refactor scan_dyntag To: Aaron Merey , gdb-patches@sourceware.org, tom@tromey.com References: <20210812042406.75637-1-amerey@redhat.com> <20210812042406.75637-2-amerey@redhat.com> From: Simon Marchi Message-ID: <6695ada0-2820-56ff-cec3-d185d3f5e966@polymtl.ca> Date: Tue, 17 Aug 2021 09:28:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210812042406.75637-2-amerey@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 17 Aug 2021 13:28:52 +0000 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2021 13:29:10 -0000 On 2021-08-12 12:24 a.m., Aaron Merey wrote: > scan_dyntag is unnecessarily duplicated in solib-svr4.c and solib-dsbt.c. > > Move this function to solib.c and rename it to gdb_bfd_scan_elf_dyntag. > Also add it to solib.h so it is included in both solib-svr4 and solib-dsbt. Thanks, this is OK, and I think it can be merged on its own. Simon