[PATCH][PR gdb/24350] Remove unused variable from windows_make_so

[PATCH][PR gdb/24350] Remove unused variable from windows_make_so

[Владимир Мартьянов]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

There is unused variable text_vma in function windows_make_so. This
leads to build error on Windows using Cygwin.

gdb/ChangeLog:
2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>

    PR gdb/24350
    * windows-nat.c (windows_make_so): Unused text_vma variable
    removed

Changelog and patch file attached

[-- Attachment #2: changelog.24350 --]
[-- Type: application/octet-stream, Size: 159 bytes --]

gdb/ChangeLog:
2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>

	PR gdb/24350
	* windows-nat.c (windows_make_so): Unused text_vma variable
	removed

[-- Attachment #3: 0001-Unused-variable-text_vma-in-windows_make_so-removed.patch --]
[-- Type: application/octet-stream, Size: 724 bytes --]

From 07b3d65f7be10e6e220a0806e1e1b2923ed15d81 Mon Sep 17 00:00:00 2001
From: Vladimir Martyanov <vilgeforce@gmail.com>
Date: Sat, 16 Mar 2019 22:23:15 +0300
Subject: [PATCH] Unused variable text_vma in windows_make_so removed

---
 gdb/windows-nat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 5caaa3b565..572457f0b3 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -778,7 +778,6 @@ windows_make_so (const char *name, LPVOID load_addr)
   if (p >= so->so_name && strcasecmp (p, "/cygwin1.dll") == 0)
     {
       asection *text = NULL;
-      CORE_ADDR text_vma;
 
       gdb_bfd_ref_ptr abfd (gdb_bfd_open (so->so_name, "pei-i386", -1));
 
-- 
2.16.2.windows.1

Re: [PATCH][PR gdb/24350] Remove unused variable from windows_make_so

[Simon Marchi]

On 2019-03-17 05:51, Владимир Мартьянов wrote:
> There is unused variable text_vma in function windows_make_so. This
> leads to build error on Windows using Cygwin.
> 
> gdb/ChangeLog:
> 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
> 
>     PR gdb/24350
>     * windows-nat.c (windows_make_so): Unused text_vma variable
>     removed
> 
> Changelog and patch file attached

Thanks, I pushed it.

Simon