From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 825383858D3C for ; Wed, 1 Mar 2023 08:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 825383858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA083210E6; Wed, 1 Mar 2023 08:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677659942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ztw9c6w6Zd1nQ+AQsTwY80fl9GA85vSxRAIU642jAa8=; b=JUfYWCHOxshEw4t5cuIevhxSJ6NgRf2RaugHOjUxBtjvFAH3kY2DgCI/Grr/8yCu0x7v/b M5EQImUpL2y7cyt9J0U+ZVMgIr/TUDEbDmUD2NgHyuQ5akp+Qq9mLhJAC1ixQjV6UzXsZX 5Z9ntbbMV7nPFpm6199nLWIyajPNKxg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677659942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ztw9c6w6Zd1nQ+AQsTwY80fl9GA85vSxRAIU642jAa8=; b=fmqVMfrjqADYNf5tQ7effk/Tx9p2HIUvIlz70meAYBwgTkZw006wYPNNPJYArr1hllzmzN 0dLYxdfcFiBl2kDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1B9013A3E; Wed, 1 Mar 2023 08:39:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m0cTJiYP/2N6awAAMHmgww (envelope-from ); Wed, 01 Mar 2023 08:39:02 +0000 Message-ID: <66dd6f17-73da-b211-8351-ad6000bcad5a@suse.de> Date: Wed, 1 Mar 2023 09:39:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Fix btrace regression Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230301014551.2840647-1-tom@tromey.com> From: Tom de Vries In-Reply-To: <20230301014551.2840647-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/1/23 02:45, Tom Tromey wrote: > Tom de Vries pointed out that my earlier patch: > > commit 873a185be258ad2552b9579005852815b4da5baf > Date: Fri Dec 16 07:56:57 2022 -0700 > > Don't use struct buffer in handle_qxfer_btrace > > regressed gdb.btrace/reconnect.exp. I didn't notice this because I > did not have libipt installed. > > This patch fixes the bug. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30169 Hi, Fix LGTM. I've also tested it, and it fixes the FAIL for me. Thanks, - Tom > --- > gdbserver/linux-low.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc > index dec1944d45f..0ca3bb1cd6a 100644 > --- a/gdbserver/linux-low.cc > +++ b/gdbserver/linux-low.cc > @@ -6781,7 +6781,7 @@ linux_low_encode_raw (std::string *buffer, const gdb_byte *data, > elem[0] = tohex ((*data >> 4) & 0xf); > elem[1] = tohex (*data++ & 0xf); > > - buffer->append (elem); > + buffer->append (elem, 2); > } > > *buffer += "\n";