From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2EABF3858C42 for ; Fri, 26 Apr 2024 14:00:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EABF3858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2EABF3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714140038; cv=none; b=mrIj2IkA9a8EqLd8eXxn21u8IhhBggmSZgzYusRTY9yhzJePZqJAEb7puh4kOW3bve1AWFULKC4/PX98P92TjY/E8gbciFBZvWmnjMNwg4wh7qHXGzWSl0xut91zz50MQxluf1cFgnXO5Y77SZSxiVqJBUVFKskDbnTuiMeHdY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714140038; c=relaxed/simple; bh=PB5Ig+tI4EblhZjJSsftwEfnfmXI3mDzD5LDeVPDe3g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=w1m3B0781y+Ohf+m2Eon0kTWXEyOfsZmyfJH48cCai7vkME0iIyaoE6mpXRr2krQFxVFIOtCYMzagY1pI4vsPmgbVJySS1hulnyAYfwxwWBWWX+TdJWiBWC5rqJLAoqKn8T3V+PLlj97HHrvPhRaQcNnwwzWPjnXwZf8cBFo3Sk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1714140029; bh=PB5Ig+tI4EblhZjJSsftwEfnfmXI3mDzD5LDeVPDe3g=; h=Date:Subject:To:References:From:In-Reply-To:From; b=i+9ecnJaAWqKqdA9pFiR6nswaZ6tdxZxtCv5gVSaObA8Z0E5Eh/FsuJP5nIsBW+Cq n6+YHNiQMmFpa4HvZv6JviTABTexx9+RTSt0qJ6ePFvo6RC5CJ0ANN3GNKvFO57JA0 Gtrjb214yyr3Nwx5HKxNfNxqDcIEwQsR621+xLzI= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 333521E092; Fri, 26 Apr 2024 10:00:28 -0400 (EDT) Message-ID: <671f4e94-f752-4ed5-8c41-513e976cafbb@simark.ca> Date: Fri, 26 Apr 2024 10:00:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING] [PATCH v2] gdb: specify sh pointer register types To: =?UTF-8?Q?S=C3=A9bastien_Michelland?= , gdb-patches@sourceware.org References: <20240401100740.939986-1-sebastien.michelland@lcis.grenoble-inp.fr> <2ecb6676-fab7-4f7b-96d0-f867990f2f60@lcis.grenoble-inp.fr> Content-Language: en-US From: Simon Marchi In-Reply-To: <2ecb6676-fab7-4f7b-96d0-f867990f2f60@lcis.grenoble-inp.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-26 04:13, Sébastien Michelland wrote: > Hi everyone, kindly pinging for process for this patch. > > Simon approved the approach on a previous version but this one still needs validation, and ultimately a push if accepted. > > I understand there is little maintenance going on for the sh target. Is there additional testing I should do to help with this patch? Hi Sébastien, I went ahead and pushed the patch. You don't seem to have on the copyright assignment on file for GDB, but I considered that the patch was small enough for it to be ok (hopefully, we can start accepting patches with Signed-Off-By and no copyright assignment soon). In terms of testing, this architecture is relatively uncommon, so I'll just take your word for it that you did your best :). If you want to go further to improve the SH port, you can always try to run the testsuite and see what fails. It might not be trivial depending on your setup, be we can always help. Simon