From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113604 invoked by alias); 1 Dec 2019 15:12:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113595 invoked by uid 89); 1 Dec 2019 15:12:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Dec 2019 15:12:31 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E9FF01E60A; Sun, 1 Dec 2019 10:12:29 -0500 (EST) Subject: Re: [PATCH v2 2/3] gdb: Rename fputs_unfiltered to ui_file_puts. To: Iain Buclaw , "gdb-patches@sourceware.org" Cc: Pedro Alves References: From: Simon Marchi Message-ID: <6720e48f-944b-000e-665e-6b4dcbdbd9ee@simark.ca> Date: Sun, 01 Dec 2019 15:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00006.txt.bz2 On 2019-11-28 7:03 p.m., Iain Buclaw wrote: > This patch redefines fputs_unfiltered in utils.c, with new behavior to forward parameters to fputs_maybe_filtered. This makes fputs_unfiltered identical to fputs_filtered, except filtering is disabled. > > Some callers of fputs_unfiltered have been updated to use ui_file_puts where they were using other ui_file_* functions anyway for IO. > > This fixes the problem I saw with \032\032post-prompt annotation being flushed to stdout in the wrong order. > > -- > Iain > > --- > gdb/ChangeLog: > > 2019-11-29 Iain Buclaw > > * gdb/remote-sim.c (gdb_os_write_stderr): Update. > * gdb/remote.c (remote_console_output): Update. > * gdb/ui-file.c (fputs_unfiltered): Rename to... > (ui_file_puts): ...this. > * gdb/ui-file.h (ui_file_puts): Add declaration. > * gdb/utils.c (emit_style_escape): Update. > (flush_wrap_buffer): Update. > (fputs_maybe_filtered): Update. > (fputs_unfiltered): Add function. > > --- > > Hi Iain, The patch does not apply for me on current master: $ git apply ~/patches/uifileputs.patch error: patch failed: gdb/remote.c:6782 error: gdb/remote.c: patch does not apply How did you generate this patch? Could you please send your patches using git-send-email? Simon