From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4559 invoked by alias); 16 Nov 2016 19:48:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4549 invoked by uid 89); 16 Nov 2016 19:48:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=chip, Hx-languages-length:1434, Great X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 19:48:44 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2E2B121A8D; Wed, 16 Nov 2016 19:48:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAGJmeDw031805; Wed, 16 Nov 2016 14:48:42 -0500 Subject: Re: [PATCH 1/2] RISC-V GDB Port To: Palmer Dabbelt References: Cc: qiyaoltc@gmail.com, Andrew Waterman , gdb-patches@sourceware.org, amodra@gmail.com From: Pedro Alves Message-ID: <675d2901-1c73-3ecc-c60e-d29c6a47622e@redhat.com> Date: Wed, 16 Nov 2016 19:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00456.txt.bz2 On 11/16/2016 07:40 PM, Palmer Dabbelt wrote: > On Wed, 16 Nov 2016 11:36:29 PST (-0800), palves@redhat.com wrote: >> On 11/14/2016 10:39 PM, Palmer Dabbelt wrote: >>>>>>> + >>>>>>> + /* Check any target description for validity. */ >>>>>>> + if (tdesc_has_registers (info.target_desc)) >>>>>>> + { >>>>> >>>>> We don't have riscv target description yet. >>> Yes. I'm amenable to adding one, but I'm not sure how. >>> >> >> You should really add them. Take a look at the ARC port, >> which was recently added: >> >> https://sourceware.org/ml/gdb-patches/2016-09/msg00248.html > > Great, thanks -- I was looking for .dtd files, not .xml files. dtd files are standard xml Document Type Definition files. The dtd file in question is features/gdb-target.dtd. I.e., the xml file you'll write follows that dtd. > From looking at > their port, it looks like I want to add a > > gdb/features/riscv.xml Yup. > > patterned off of > > gdb/features/arc-v2.xml > > It looks like there's a whole bunch of examples in there, so if I'm on the > right track I can probably figure it out. See here too: https://sourceware.org/gdb/onlinedocs/gdb/Target-Description-Format.html FYI, with target descriptions, the remote stub send a target description that includes whatever custom registers the chip has, and gdb will include them in "info registers", etc. all without any gdb modification. Thanks, Pedro Alves