From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id A63ED3858D20 for ; Thu, 7 Dec 2023 18:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A63ED3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A63ED3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701973180; cv=pass; b=vsKBXGOSNfmcKKfL+ui3VQLf50eP3G7ulb+Um45tynSzHfXTr9/0N3HCleAQOAGZ6hLrPg+5tfuttLDtY9mCRS3FMUMVWcW9E+qbLFxVP/A3ZwVDSIcwW8EQLU6hU1QnIo5KTAplpZxdWvWqLK3PVlZeypDuKMqvBNSZrDJt0v8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701973180; c=relaxed/simple; bh=uMLf5hWamecHZ2LggXT2m3Nnuy1/cZWL16AL2C3aMSE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JGHLysumfamG9K/BkoVnXDtfOhj8pYf9sPvImoep6LFMNZhJsvardM+KNRWUpkSF9PrZsrqQb2Rpc8iJBRKXJ/eSuyGcBWOxBjcQ8r6JHeqNHg7z194Fkx6/QDxrHJHVQJ546NO7qq5RPddRjc69st5IdOCCQaz7zEP2c/godyQ= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4SmMxL08hmz3DPF; Thu, 7 Dec 2023 18:19:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SmMxK6Rgcz4fX2; Thu, 7 Dec 2023 18:19:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701973173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OgVsBmxEIUIRP9uBORGpnI20pY4N3f4/VgFB9t9qDZY=; b=SaTWUer4a9BtphDl11rjPdkOf9/ohzvAdpHUM+kTORb6ouLLiBJg9306k37d4mcrwilCqq V82mYjjXl4/0YzlR6bVl1yreBYY+coqgkdEcytNeaax4pxIQBzyNHBuNmGxjR0ooNEWxye Qcc7j3mNwpQvM9G782Yw999wA8M3itMcVDm0UbipDQ3j2F8+QxmFKvOa3xjaE6trcCZy4s nwz/nw6TOBgiTZFcKaRMihVhDStmtjlK1EwNNxCjC7IjRuhN+mMxceGs6khHhuJxzkkxv5 81I5YpTeRO0ggvHB2jdql2jhrMbOzPmBo7KLPOqS4IRNNm0GtlB68XzQKd0qig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701973173; a=rsa-sha256; cv=none; b=V9nSmyuHouBLW0o4UTzLQ+vykdegpcVzFQJVMHJyjWVPyVlZrVwt+vxhbvSnl8MgcxZHGS 25Ery+32FAA2Ak9JScWqBGDsWUnEg7taMesDwYp/17dHAaRXn6omZW5B9597q2R4SY0CTA P1u2DZ/DQUWCvDEt7H8CClFa6Vzs9QkIAFYZ7H4/q31ZvCaP9r9ixwjqclu7QuifG/CTGZ H6o1zN0Td9AFSP3FIlNzIrFhaJ/N9vt6cgJboriAsQXVFb/nmyvEEb6GW71eFlcBiaiGQm nX6nuIIQ27/Kcz0HFv4Pq2zTHX2z1yVqgkqJHA8MC+Zuld/eCxFknIwehUcFzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701973173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OgVsBmxEIUIRP9uBORGpnI20pY4N3f4/VgFB9t9qDZY=; b=uNTpLE97CqYyDynK9sa6aG9667POzGOKkqx7zo/BpGETN8NwgsynnVVIlJErF5leEQIOTv LtoLwLkisEYUCNb82R8ZYVdOrOPNg51m9vatFdsBU+8BfZg25cZ1So73rdciILOaWOSEzW h4qG4nJ2qi5uHLR+ST1NNlEf2rTdhdXYESIv9xNzdBTvqc33Aze/oU6LXRyuBYuBNo3R0/ FcSafiaN1pGBipWpvUlfke7ce9CLeixH+efcmflnpA2hBeQODjYXKnYm6Fh9tAnfxVgXuN 0jN71K4mfa1Aw9ohBd6aX5XTEH1+j6zbEItwVF1EblqRsIqUBGOv7E4sD80HtA== Received: from [IPV6:2601:648:8384:fd00:188e:d0e2:a5b6:22f1] (unknown [IPv6:2601:648:8384:fd00:188e:d0e2:a5b6:22f1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SmMxK2WNqzD4X; Thu, 7 Dec 2023 18:19:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <676d4bc8-e482-4fd7-a4ef-278c6d7d6e34@FreeBSD.org> Date: Thu, 7 Dec 2023 10:19:32 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7] gdb: add git trailer information on gdb/MAINTAINERS Content-Language: en-US To: Guinevere Larsen , gdb-patches@sourceware.org Cc: Kevin Buettner , Luis Machado References: <20231207173415.2311804-2-blarsen@redhat.com> From: John Baldwin In-Reply-To: <20231207173415.2311804-2-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/7/23 9:34 AM, Guinevere Larsen wrote: > The project has been using Tested-By (tb), Reviewed-By (rb) and > Approved-By (ab) for some time, but there has been no information to be > found in the actual repository. This commit changes that by adding > information about all git trailers to the MAINTAINERS file, so that it > can be easily double-checked. Simply put, the trailers in use work as > follows: > > * Tested-by: The person tested the patch and it fixes the problem, or > introduces no regressions (or both). > * Acked-by: The general outline looks good, but the maintainer hasn't > looked at the code > * Reviewed-by: The code looks good, but the reviewer has not approved > the patch to go upstream > * Approved-by: The patch is ready to be pushed to master > > These last 3 trailers can also be restricted to one or more areas of GDB > by adding the areas in a comma separated list in parenthesis after the > trailers. > > Finally, for completeness sake, the trailers Co-Authored-By and Bug > were added, even though they have been in use for a long time already > > Reviewed-by: Kevin Buettner > Reviewed-by: Luis Machado > --- > gdb/MAINTAINERS | 96 ++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 88 insertions(+), 8 deletions(-) > > diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS > index 38c982ef7eb..f86aa8818a0 100644 > --- a/gdb/MAINTAINERS > +++ b/gdb/MAINTAINERS > @@ -43,14 +43,9 @@ patch without review from another maintainer. This especially includes > patches which change internal interfaces (e.g. global functions, data > structures) or external interfaces (e.g. user, remote, MI, et cetera). > > -The term "review" is used in this file to describe several kinds of feedback > -from a maintainer: approval, rejection, and requests for changes or > -clarification with the intention of approving a revised version. Review is > -a privilege and/or responsibility of various positions among the GDB > -Maintainers. Of course, anyone - whether they hold a position but not the > -relevant one for a particular patch, or are just following along on the > -mailing lists for fun, or anything in between - may suggest changes or > -ask questions about a patch! > +The word "contributor" is used in this document to refer to any GDB > +developer listed above as well as folks who may have suggested some > +patches but aren't part of one of those categories for any reason. > > There's also a couple of other people who play special roles in the GDB > community, separately from the patch process: > @@ -78,6 +73,91 @@ consensus among the global maintainers and any other involved parties. > In cases where consensus can not be reached, the global maintainers may > ask the official FSF-appointed GDB maintainers for a final decision. > > +The term "review" is used in this file to describe several kinds of > +feedback from a maintainer: approval, rejection, and requests for changes > +or clarification with the intention of approving a revised version. > +Approval is a privilege and/or responsibility of various positions among > +the GDB Maintainers. Of course, anyone - whether they hold a position, but > +not the relevant one for a particular patch, or are just following along on > +the mailing lists for fun, or anything in between - may suggest changes, ask > +questions about a patch or say if they believe a patch is fit for upstreaming! > + > +To ensure that patches are only pushed when approved, and to properly credit > +the contributors who take the time to improve this project, the following > +trailers are used to identify who contributed and how. The trailers (or tags) > +currently in use are: > + > + - Tested-By: > + > + Used when a contributor has tested the patch and finds that it > + fixes the claimed problem. It may also be used to indicate that > + the contributor has performed regression testing. By itself, this > + tag says nothing about the quality of the fix implemented by the > + patch, nor the amount of testing that was actually performed. > + > + Usage: "Tested-By: Your Name " > + > + - Acked-By: > + > + Used when a responsible or global maintainer has taken a superficial > + look at a patch and agrees with its direction, but has not done further > + review on the subject. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma-separated list. > + Usage: "Acked-By: Your Name (area1, area2)" Suggest a new line before Usage: here. > + - Reviewed-By: > + > + Used when a contributor has looked at the code and agrees with > + the changes, but either doesn't have the authority or doesn't > + feel comfortable approving the patch. > + This trailer can be specific to one or more areas of the project, as > + defined by the "Responsible maintainers" section of this file. If > + that is the case, the area(s) should be added at the end of the tag in > + parenthesis in a comma-separated list. > + Usage: "Reviewed-By: Your Name (area1, area2)" And here. Otherwise, LGTM. Reviewed-By: John Baldwin -- John Baldwin