From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Rename regcache_cooked_read_ftype and make a function_view
Date: Wed, 20 Jun 2018 17:23:00 -0000 [thread overview]
Message-ID: <67821f9f19a3f7b6d1a58a46a62f4efa@polymtl.ca> (raw)
In-Reply-To: <20180610215128.20236-1-simon.marchi@polymtl.ca>
On 2018-06-10 17:51, Simon Marchi wrote:
> regcache_cooked_read_ftype can be converted to a function_view, which
> allows us to use lambda functions and therefore avoid having to pass an
> opaque pointer parameter.
>
> Adjusting the fallouts showed that the "const regcache &" passed to the
> readonly_detached_regcache constructor is cast to non-const in
> do_cooked_read. I changed the constructor parameter to be non-const.
>
> Finally, I renamed the typedef from regcache_cooked_read_ftype to
> register_read_ftype, since there is nothing that forces us to use it
> only for regcaches nor cooked registers.
I pushed this.
Simon
prev parent reply other threads:[~2018-06-20 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 21:51 Simon Marchi
2018-06-20 17:23 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67821f9f19a3f7b6d1a58a46a62f4efa@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).