From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38728 invoked by alias); 20 Jun 2018 17:23:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38603 invoked by uid 89); 20 Jun 2018 17:23:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=forces X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Jun 2018 17:23:30 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5KHNN4U023930 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Jun 2018 13:23:28 -0400 Received: by simark.ca (Postfix, from userid 112) id 18C991EF28; Wed, 20 Jun 2018 13:23:23 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6590B1E481 for ; Wed, 20 Jun 2018 13:23:22 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 20 Jun 2018 17:23:00 -0000 From: Simon Marchi To: gdb-patches@sourceware.org Subject: Re: [PATCH] Rename regcache_cooked_read_ftype and make a function_view In-Reply-To: <20180610215128.20236-1-simon.marchi@polymtl.ca> References: <20180610215128.20236-1-simon.marchi@polymtl.ca> Message-ID: <67821f9f19a3f7b6d1a58a46a62f4efa@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 20 Jun 2018 17:23:23 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00500.txt.bz2 On 2018-06-10 17:51, Simon Marchi wrote: > regcache_cooked_read_ftype can be converted to a function_view, which > allows us to use lambda functions and therefore avoid having to pass an > opaque pointer parameter. > > Adjusting the fallouts showed that the "const regcache &" passed to the > readonly_detached_regcache constructor is cast to non-const in > do_cooked_read. I changed the constructor parameter to be non-const. > > Finally, I renamed the typedef from regcache_cooked_read_ftype to > register_read_ftype, since there is nothing that forces us to use it > only for regcaches nor cooked registers. I pushed this. Simon