From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 123B93858D28 for ; Wed, 25 Jan 2023 18:14:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 123B93858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AA5EA1E0D3; Wed, 25 Jan 2023 13:14:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1674670472; bh=mHaKaoxY7TCdOzCFjrV3G1S4aXIcMAF7SUpj5h990FE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=hH0fVw1YLwqf5ucsBvoIdwzKJWr56DvPl3u7YdeGCxRtXqbInd5abclAyCfQz26Rn IgHW28swA7I7NXxExPW34wKBBnqtKjCVXjVywpV9UxiURVTFM95gzWsDzndx8Ys+GX eB0yv/2lpt/edKe8nEUDK+BRQXu860Ah4l+kAapM= Message-ID: <67a9bf80-87b5-0a62-49ad-a9cac8ca6109@simark.ca> Date: Wed, 25 Jan 2023 13:14:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Clean up unusual code in mi-cmd-stack.c Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230125150609.3987536-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20230125150609.3987536-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/23 10:06, Tom Tromey via Gdb-patches wrote: > I noticed some unusual code in mi-cmd-stack.c. This code is a switch, > where one of the cases appears in the middle of another block. It > seemed cleaner to me to have the earlier case just conditionally fall > through. Thanks, that LGTM. I would have been very confused if I had to deal with that code. Simon