From: Simon Marchi <simon.marchi@ericsson.com>
To: Omair Javaid <omair.javaid@linaro.org>, <gdb-patches@sourceware.org>
Cc: <simon.marchi@polymtl.ca>, <tom@tromey.com>
Subject: Re: [PATCH v2] Fix lost line info for symbol at addr zero
Date: Wed, 27 Jun 2018 13:22:00 -0000 [thread overview]
Message-ID: <67dfe221-34cd-8bfb-59c1-65bf51d1b7f2@ericsson.com> (raw)
In-Reply-To: <1530090567-26491-1-git-send-email-omair.javaid@linaro.org>
Hi Omair,
The patch LGTM, except maybe a little nit in the test.
> +# Check if we are able to read offset adjusted line information of main
> +
> +gdb_test "info line main" \
> + "Line.*starts at address.*and ends at.*"
>
I would suggest matching the 0xffff000 part of the message. This test requires
the symbol to be at address 0 to really reproduce the bug. If, for some reason,
the "main" symbol did not end up at address 0, the test would be pointless and we
should look into it. Matching the 0xffff000 part would make it generate a FAIL,
which would attract attention.
You can push with that addressed. (You have push access, don't you?)
Simon
prev parent reply other threads:[~2018-06-27 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 9:09 Omair Javaid
2018-06-27 13:22 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67dfe221-34cd-8bfb-59c1-65bf51d1b7f2@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=omair.javaid@linaro.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).