From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66830 invoked by alias); 27 Jun 2018 13:22:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66449 invoked by uid 89); 27 Jun 2018 13:22:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 13:22:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1530105748; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wFvyU6AuSQgvO0n4lHhjE9jDyNtCvE83uXvRC6jSeLQ=; b=K7UIBNImA22JM6Qe6ZAR7wXkH1UF9aIZHL7QRfcaBT+MiqhIOjW0SApz8o53sl2O gt37j6pSfHuk2/KHHlPH2PgSN4dB/I4wRZrgEklLfRaN10vg/M9HY/n81KuE7SKM 0VmTW6QsjL8NDTOnLUuIzvg+FVO8llxDnFXqPnYFg4g=; Received: from ESESBMB504.ericsson.se (Unknown_Domain [153.88.183.117]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id AB.C3.22015.49F833B5; Wed, 27 Jun 2018 15:22:28 +0200 (CEST) Received: from ESESBMR501.ericsson.se (153.88.183.129) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 15:22:28 +0200 Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESBMR501.ericsson.se (153.88.183.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 15:22:28 +0200 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 27 Jun 2018 15:22:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnrH4u5J4BLfm8HLeCatWABReJPDCehdwtClDZd7gMA=; b=KrNOixZFkEDS9fhyAW/4N160q2IbbWMaoUK8hTxHFh6MtLwD2umqzVusd5mard/XpowV9nLsOIZfClnpmp/k1hX5pAOFq9AT4uKOJjdwBjlogAD3/DDBRUy20JDjwDJALkIVLavFWhVxONdcOX80nZyLQtiwizM0qbyzod1uxDI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.229.156] (129.192.64.65) by SN6PR15MB2397.namprd15.prod.outlook.com (2603:10b6:805:24::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.20; Wed, 27 Jun 2018 13:22:25 +0000 Subject: Re: [PATCH v2] Fix lost line info for symbol at addr zero To: Omair Javaid , CC: , References: <1530090567-26491-1-git-send-email-omair.javaid@linaro.org> From: Simon Marchi Message-ID: <67dfe221-34cd-8bfb-59c1-65bf51d1b7f2@ericsson.com> Date: Wed, 27 Jun 2018 13:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1530090567-26491-1-git-send-email-omair.javaid@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00645.txt.bz2 Hi Omair, The patch LGTM, except maybe a little nit in the test. > +# Check if we are able to read offset adjusted line information of main > + > +gdb_test "info line main" \ > + "Line.*starts at address.*and ends at.*" > I would suggest matching the 0xffff000 part of the message. This test requires the symbol to be at address 0 to really reproduce the bug. If, for some reason, the "main" symbol did not end up at address 0, the test would be pointless and we should look into it. Matching the 0xffff000 part would make it generate a FAIL, which would attract attention. You can push with that addressed. (You have push access, don't you?) Simon