From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72744 invoked by alias); 31 May 2018 12:06:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72727 invoked by uid 89); 31 May 2018 12:06:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=title, sk:alan.ha, psuedo, alanhaywardarmcom X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 12:06:32 +0000 Received: from ESESSHC003.ericsson.se (Unknown_Domain [153.88.183.27]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 05.2E.00712.545EF0B5; Thu, 31 May 2018 14:06:29 +0200 (CEST) Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSHC003.ericsson.se (153.88.183.27) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 31 May 2018 14:06:21 +0200 Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 31 May 2018 14:06:21 +0200 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 31 May 2018 14:06:20 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by DM6PR15MB2395.namprd15.prod.outlook.com (2603:10b6:5:8d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.820.11; Thu, 31 May 2018 12:06:18 +0000 Subject: Re: [PATCH 5/8] Add aarch64 psuedo help functions To: Alan Hayward , CC: References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-6-alan.hayward@arm.com> From: Simon Marchi Message-ID: <680d01bb-e6ec-3d9e-e8a8-29d7c7bbf530@ericsson.com> Date: Thu, 31 May 2018 13:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180511105256.27388-6-alan.hayward@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR02CA0045.namprd02.prod.outlook.com (2603:10b6:207:3d::22) To DM6PR15MB2395.namprd15.prod.outlook.com (2603:10b6:5:8d::29) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM6PR15MB2395; X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2395;3:CIEgRr+5Sj5TpnIP/xzP1tpIec0KjNPo89Yqr0M0n6rUemf1LPNt3mVCUySUM+olH5YLDmIC7UgRESHdrKB1x0+e0SuL3Z2vTJBbWPNuMBKonnhS7lUuUsw247nwukFZUiEnorvVHDC+oBu5j1kDFW+dQVx19W6BAHHDXzr/DFIPhc9nUe8B9NG54C3ozApQnpAYOfAXF7pnRWl+WxPwRyrOWWRGUbmrQpTuwZGdwBURObdvRlThZXyBynFVp41s;25:Jnw1zgkIwFXHpJzh4CQWIL3D0yeahGdC+47WBaps7oNjHxQQH8fRhmZLBlLjOaN8WH6glkqfxJK8YCHAiAMyQVqqHO9NPgeVf7iClR9w2yNYKKbnm9E1H3u9wjppzjkJMAd3r3E2ngeUhYdIdegs4WoGPjmnzypUOUsAgBGalmiSiZdQByVkp7Y9qHXzh+Fd4SdWdPpFsP9ftP97ZTpPW086mh3x41Hx+sDDDQQZwPeNDhPy2mGLL9rpNLOXw7/KRYj4Q9509il1zoksEJ5O8VDhoiKxp5hBPxrzOrbZMRRuJAFCcq2UUHZYZs86LV+CrPEIN+0r/KfUogE1j3qxNg==;31:WsApibg1FunLUhdtlGuuQt+gL7p9iZfBgR/brhPlfpBU7fpmZkEBzZomNYkYrkYkMIpoam/i5SH6h96L1oO/f2EmPSZ0s8VQhLXEG3abUJAoaFvA4DuLoQHLzETyH+aT5/9PYPePKnQLFrpHQwQQ+k19lYrNQMhMVRfzMxrpUtk4/173KTSFox3j+3CCqV8ocqUCUfHHxHul+aEUk2oK1bKcoqujaXDX/DwFklDtgQQ= X-MS-TrafficTypeDiagnostic: DM6PR15MB2395: X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2395;20:J9ixBXE4K4YrTTortiv5zh9mYUqJ9vSJ6IlheWDcXl/wLABrtBlisjIKP5KIbC+cSuDY1/ZMcQN/8zaBBaCqhtCk4PP5m3pOWYIqf/meHezeRg5nmboUhWJdS4qExceSU1HTnH/8o1krYh60X9U7e8neuXfDeIguZisCyLNxBZ7Q/Z/IpCy9bjDMi2SdIkrmnAcA8IylAA1bIO4CpIpKrAXf4Rnynmwa+K9tZixgrUxktzp8RZc3U1kr+QJ7SrFr3yNexr6UDrWoTmTfj+EadkLnx9/LYnMLnTxLyCgW49RiN/yHJFYDDa13j4frWdDHWRJ3id9QmVce6NBwVxDD70U8DAT5ZEHIRHhS0GeDRO3/KyF87Gg9ExtMI5zOenBTCcn9S5Vgy5DnwX37wWP0s2q4YPyDjYgDc8TWJcvOzAC+1gPg8mUbHqIzFNaXgx6B2vAx7XIl8Tk3ASw4R+lz0V5wQ8wLLKP1zCZgd5yH5NFbvVT4oE6wh6kev89gFMyZ;4:0VCxsLiGAN8kGJZSTfL1AbEmt1sQmHTBqK/WyorX6pGSrjI3r2lgWoLoSWFQP09DMRpN++etAkrQl17kUVMC1+dmANDoVL7vK0PSfiCH74tASVdBsQdtTF5+rXjk/lu04QgF0v0bOoZe4t80rSPO4GC5YhflX2jL2+Fp17Ob5qYsc2MRFEcm64y86CjK0WcLzj8MCR1Zbee7GsCqcIkA+Y0Uc+D6Rk4GyvQIgKG0G0D9NgERuby5S1h0+kO55B6Me/cuaEllrbtdcOty8FItvOHOWbyjcyTkIPAwqu8Pc4zfoB1iFW+r9kWxN/WlHAy6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016);SRVR:DM6PR15MB2395;BCL:0;PCL:0;RULEID:;SRVR:DM6PR15MB2395; X-Forefront-PRVS: 06891E23FB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(376002)(39860400002)(396003)(39380400002)(346002)(189003)(199004)(6486002)(65806001)(229853002)(66066001)(65956001)(2906002)(16576012)(316002)(58126008)(68736007)(31686004)(53936002)(6246003)(77096007)(26005)(76176011)(386003)(53546011)(105586002)(106356001)(97736004)(65826007)(47776003)(478600001)(5660300001)(52116002)(2486003)(186003)(16526019)(52146003)(4326008)(23676004)(81156014)(81166006)(86362001)(64126003)(50466002)(8676002)(305945005)(6666003)(230700001)(25786009)(7736002)(8936002)(31696002)(36756003)(6116002)(3846002)(11346002)(44832011)(446003)(486006)(476003)(2616005)(956004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR15MB2395;H:[10.0.0.110];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTZQUjE1TUIyMzk1OzIzOnN1WGNHWUYwUDhISWk2Q2ZRZEdXbGZ0OSt5?= =?utf-8?B?alZ5ODFEVXN2aXIyYmd6dUtIRDNvWW1uNEQrRGJUNlpzNXNLTGZjaElSZVFj?= =?utf-8?B?bjFyaURpWmxXMjVsdDNEZEgzMGtVaTdIMjFDeVNYRjlhTzYzUkZOYWJjWW50?= =?utf-8?B?Q0xjMlpZTmdsR1ZGcjB1M3dsRThtL0RWWVpFRlpna01NRkFOempLNTBFVkRE?= =?utf-8?B?WU1ycWw3cjJ3M0RIb05JRk03MlZiQncrMVVOMGNBaUxjSEVTVmtaNjcxME4x?= =?utf-8?B?R1dueVlmUTdGUlUrdUpTTjE3RFEySVhVR0tVa0t3MXdTM29RZEd2aEV5T2ov?= =?utf-8?B?U2NJQTZnbXJ5a1BzRzhJTUlsZk5FWDFMYVIzTGtBY0VxOUYrRHNDSEV1cVF1?= =?utf-8?B?NXBMT2M0cjNHWmpiaENORmFXVXV1OW5BMW9PRWJxN1hmTytCWXhrSzcySGc2?= =?utf-8?B?M1dQUlJiTXRLQTlYaEpQejF3dHVBM3laUm5vTWY0UU84NXdSTnpNL2ZkdkNK?= =?utf-8?B?MDRtZDNZdkRhM3pNQ2R2T3VBd2lndGg0bXNwMjJUNkN4ajEzQnQ3MTZTZm9h?= =?utf-8?B?aW9CZDltRzFXR2l6RVdpakNmMWdhNjNmRGdqOUNjajVodEpjWFNWSFNwNnpD?= =?utf-8?B?RFY2YzN0UHMyWUNBMG0xc2RzQzJyOFlTZSt4b1dwMS9pc21kQTVvMWh6cnZl?= =?utf-8?B?QzBETTNVLzdKZjI5ZnhOQlJ6b293dnJ1dUhkY3RCYXF5SVpsMXVCT21QY0k4?= =?utf-8?B?MUpFMm85ZGNxUXRyK2Z4OS9zVEpxRmhnOHJlQXhZQnNTUmEyTWdWb21IQ0d5?= =?utf-8?B?MlFQZlFZeDlaek11YkZwdWY2cWVBRFNUclNaWFVFOElvYlkxSVJURU05emc3?= =?utf-8?B?NmhhV1dnaTE0N1NFaUU2S0ovcXNQdTVNN3owSzFwMmN6ZFBWeUdCWmlVOHBk?= =?utf-8?B?WUVQL0ZGUGtnbSt6Qlc3QzhhcHpEYURxR3FOOW43OVczQVhUcmV3WFhwZjdM?= =?utf-8?B?dlBnYkNxTFI1VzVpUldZUkwrNW1lcjhNZTViWEZGSVNpMWI3RGJ2M1hlVytv?= =?utf-8?B?RjVSSnIrdlA5d0VzcFZYdU1TeTNIeHRkMEE0RDNXQUpuZ21LZEFBTnl5cFd4?= =?utf-8?B?dndNQlhUQ0RXUzFIR0ZjUEtmbXZLUWVzN05QaGNyUnNTeHBOQ1ZRVUMzVXc5?= =?utf-8?B?Z29ZUmtDalYrZFlSTU0rQWJnYXgxWjlycHhnRmNjYjlPdHFjL3BDZlZudG5h?= =?utf-8?B?N3psRUtYbm15WXhQNWRTQlV6M3AzNmFmb3JlMzNEUWJ1STAxZnpOVDYyTStv?= =?utf-8?B?S25JVVhSSSs3aHZZQUFCOW5Zc2hWenhJTUdobStEMzIvanlMckdNVWtSTzBn?= =?utf-8?B?bkZBZExoTVBEY2Q0RmVYaDRFbG55RCtoQ0pUaEVzMVpBY25OT1YwWklPNzdH?= =?utf-8?B?cW5RVGR1MmxXcTRzbkU4QnN5dzd4UmUyRTl5QkRUOEVjUFVwb0FCQlFjTkZr?= =?utf-8?B?cUVpRHJUYlRCekZ2OURXSnBrRWk3MHFoZU0wOTZTR2dZMFM5THVIMGxqa29t?= =?utf-8?B?anNPYWlmNlNsQWUyNG55d1U5NklNbEkvYTBIMUIxMW1rWVJDdm9jUjd1c05w?= =?utf-8?B?NmZTYzlhSno4U2pEQzFyaTg1M2w5Zm9YYVVKZTdudWNocE5GcXV0VGlSL2Nm?= =?utf-8?B?djYwbkV5STlxcGxvem03UDZDVnp5R1JNdTc2cllKN1V5TjFERTQvVCtqenpS?= =?utf-8?B?ZU9ubHZhR1RYU0pqOGVvS3RkOGI2bVZlYVVaczNnNHpzQk5JZTAvTjFlYkRx?= =?utf-8?B?SUU1QnJydXhrZ2pXR0w0b1hBQlNCR2ZrVXh4UTBaRC8rTWJucWUxOXl5bHcx?= =?utf-8?B?TEJDMTRRZkxoS1BsSlBLNG9McWRiOUlaTTBPV0FiRnQ2TEVYQXB3QUdGbEQ3?= =?utf-8?B?cFhxT0haNWNBPT0=?= X-Microsoft-Antispam-Message-Info: DFJJmTzky967kZyH1XOlk2Nl9I7Q6OhEnOcX36ZeQ98NDbNROhRW2SbofKMy0rTycSaq83yVmT+AbG6KSs+cUvea7Rllt1OUmGVD37paTtGVFq5XVDQymvknSTsVD+s/XlTV037TISXGP4HkNXi2qCKpc5xCIT6wbshOxiHtNtLgdyKVFvuN3aO7z5DY/vHi X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2395;6:qVulAQvuI8A36JhEaJK0s/O7vJel2KgWNUsj7JiCr52JDbWwlR+g0IUbGPjzjpOnAU/6+GoZpimDE808fsR+NJ0feuHW6d7Kfh4jUHoDTdzQ6jQvBFLOSzf5+/ilYEYwlY3Xa+hs5G0faQJkpuJW84XHT1Lpf0GIuovTf8+WlgaB15umZAHwlq1Z2opEG8BKNEvmr3rOEPXLPLh5+3hTECwN1awEiTFL1VvexkakxaJpXJjkSpF9xs0phASnlXYTx419ckhJ4Y0JgWLw2fzQdjt+Pn1Prw1VMgOwy5I5b9DRO1SRRMNn1X3YYWFposvrEKlGD/VLWMNeP0ToHMmbVi0vmk2AjQWIE6VOreItEqLdTmLH8Lx11NZrIBECwEEBxACFYsYmqCUU2/niWhbA9p68MX8AG7ChKy5oQGmhRqoj+q//G0ivkTar0waDmRfz6oM/QlBUdfa9ItP01vEHng==;5:KIvwwtrpfamzYZpkjZTO71NeKgMVYGxgNY36EqXCe9pQBpm4ql7bMmEXQwGbboloua4Q5sYzyVwioLK88CAyCw3p+HzXBxwKeMhriAQa0bz6kiA98hDD2fgO36clDejHFOKejLo870bxumk6nQxqCwgiCymnn7SA6lKWlOOu/jQ=;24:HCC5+l67dRhDPdA2fYmCJjOnf3YyDBb6H5csH6t6RxOqLi2jRD1M6hPcK1ToC//t3Rd2jl/hky9u8EaZ/HZM5ijTsX0eEMRMddoOUQGUbGs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM6PR15MB2395;7:ziprHPcG9ZmMGoBKm2RPQEgX8V9mBgXRSYR/4zucZqWp6jetF6zecL0aw2+2CmwkwjhhfhWh6mMkg6wIhBvlR5uYyzhDUOJAiilQaIt1r2Jh7Wzy6XeYeDfiRFI9DGlT4dvV3GoVb7rX6w2oPDKEa5CpDpW2ScLEwVGjnDSj6pOqyPx9YRieQ2nfFfMUnEWVRd7sXT0htSctxoEHhVLges/mr3/TsaDFwvz15iFyNTwcM2eDIQSiSxIOK5Zb2QuJ X-MS-Office365-Filtering-Correlation-Id: 135057b4-7d7a-4e16-a777-08d5c6eeeb39 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2018 12:06:18.9202 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 135057b4-7d7a-4e16-a777-08d5c6eeeb39 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2395 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00844.txt.bz2 psuedo -> pseudo in the title. On 2018-05-11 06:52 AM, Alan Hayward wrote: > Reduce code copy/paste by adding two helper functions for > aarch64_pseudo_read_value and aarch64_pseudo_write > The patch does not change any functionality. > > 2018-05-11 Alan Hayward > > * aarch64-tdep.c (aarch64_pseudo_read_value_2): New helper func. > (aarch64_pseudo_write_2): Likewise. > (aarch64_pseudo_read_value): Use helper. > (aarch64_pseudo_write): Likewise. > --- > gdb/aarch64-tdep.c | 173 +++++++++++++++++------------------------------------ > 1 file changed, 54 insertions(+), 119 deletions(-) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 7893579d58..003fefb3c9 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -2247,109 +2247,67 @@ aarch64_pseudo_register_reggroup_p (struct gdbarch *gdbarch, int regnum, > return group == all_reggroup; > } > > +/* Inner version of aarch64_pseudo_read_value. */ > + > +static struct value * > +aarch64_pseudo_read_value_2 (readable_regcache *regcache, int regnum_offset, > + int regsize, struct value *result_value) It's not a big deal, but in other GDB parts we actually often use the _1 suffix for the helper functions. But otherwise, LGTM. Simon