From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DFE823858002 for ; Thu, 15 Dec 2022 17:04:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFE823858002 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1D95D1E0D3; Thu, 15 Dec 2022 12:04:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1671123888; bh=6L95s0j0zpki9rhfScNZsRf3AB6c/BALWVKK4Tc9C8Y=; h=Date:Subject:To:References:From:In-Reply-To:From; b=bbw+zA+sMVZauZ+iLA9LKFKvjx3OS5Li2tPwBbD8psxit1ISlx7yE4acuSXGZORWX Gk5ZP+W0sSXfJjY2+rmeBanHskmdhk7hoja8YdN9o40FQLxaxMfC3NjET8jW3OjXJ7 WMJ354q4eokJLdQpxKLmbw0I0oEHHsgd+Yty1Bx0= Message-ID: <680fe4f2-5ac4-37cc-dd64-3c38f0df9d2e@simark.ca> Date: Thu, 15 Dec 2022 12:04:47 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PUSHED] gdb: make more use of make_target_connection_string Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org References: <53cf95c3389a3ecd97276d322e4a60fe3396a201.1671108652.git.aburgess@redhat.com> <2d9e0814-b4a8-fba8-9422-a1c746a15ebf@simark.ca> <87o7s4zjyq.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87o7s4zjyq.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Normally I'd just push the fixes for this as obvious. But as that's > what got me into this mess in the first place, I figure I should post > the fixes here first :) Hehe :). The patch LGTM, you can add my: Approved-By: Simon Marchi ... such that if the patch ends up incorrect, you can shift the blame on me. Simon