From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1D7753858CDB for ; Wed, 18 Oct 2023 20:26:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D7753858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D7753858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697660804; cv=none; b=E3MFDLT3nWOZvqTL5Iuo5/N/+Eakelo3yh2wJxtd6DM2c84loN/g39qwR4XpuYaUBuBNOr6ERLDRTBKa1BZcBMYl2dIQwZNjNUnycg+xBD6BgrJfZHnvUGrlFcpWEzg5zNh/BU07nXKHkf+6QJePyLj+kfRB6NqQUJRjV2tF89Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697660804; c=relaxed/simple; bh=y3Mjn4gZ8mbJZxkeQFYDaiSQsJg0q9pvr1ieTIAq2c0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=puYpnOfql22dnSa7rkgXtICd7QnbxejpXj5m7lF6tcI1mGmXMMWk1t5HVoAkTSQf8N46RKDK7WBeuHWQdm7/8TX2eKiZvAujoGyO35ee175OGc4uqurHJND2gjHUPXrbUsEvHgx3YgFqZf2K16MrHCEmRWiBG12sh/YuMHobMLQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1697660802; bh=y3Mjn4gZ8mbJZxkeQFYDaiSQsJg0q9pvr1ieTIAq2c0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=T9ft5OnK0+x7m1NUP+ugR737qlPh6nyz20JfdgEnQFrcLfSCFAmLIlR+xYrZIlOb2 xzYxEOUkirxuEkPFZHgGqRcVZY/0fPDLqHPk+3mwl/uv7PZrsuCogTHu//6qPFGPWu KUP//eeZg5CW2kHmdE7Y1kbaK0xGNJUR5YRkAYxQ= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C4EE81E091; Wed, 18 Oct 2023 16:26:41 -0400 (EDT) Message-ID: <68321ac8-a980-4832-be5c-01a4e8e3e21b@simark.ca> Date: Wed, 18 Oct 2023 16:26:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp To: Lancelot Six , gdb-patches@sourceware.org References: <20231017111629.307261-1-lancelot.six@amd.com> <20231018102453.355287-1-lancelot.six@amd.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20231018102453.355287-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/18/23 06:24, Lancelot Six wrote: > The gdb.rocm/multi-inferior-gpu.exp testcase uses a "continue $thread" > command, but this is incorrect. If "continue" is given an argument, it > sets the ignore count of the breakpoint the thread stopped at. > > For this testcase it does not really matter since the breakpoint is not > meant to be hit anymore, so whatever the ignore count is won't influence > the outcome of the test. It is worth fixing nevertheless. > > Change-Id: I0eb674d5529cdeb9e808b74870a29b6077265737 > --- > Changes since V1: > - Following Simon's comments, remove the "continue" -> "continue&" > change. Even if this test is in non-stop mode, this change should not > be required to esure when the GDB prompt is seen. > > Best, > Lancelot. > > --- > gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp > index 18b4172ff09..5bac50d2ef8 100644 > --- a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp > +++ b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.exp > @@ -68,7 +68,7 @@ proc do_test {} { > foreach thread $stopped_gpu_threads { > set infnumber [lindex [split $thread .] 0] > gdb_test "thread $thread" "Switching to thread.*" > - gdb_test_multiple "continue $thread" "" { > + gdb_test_multiple "continue" "continue inferior $infnumber" { > -re "\\\[Inferior $infnumber \[^\n\r\]* exited normally\\]\r\n$::gdb_prompt " { > pass $gdb_test_name > } > > base-commit: fded0fb898618b5b659762ace776144afa876035 > -- > 2.34.1 > Thanks, LGTM: Approved-By: Simon Marchi Simon