From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 7907838515FB for ; Tue, 3 Aug 2021 18:35:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7907838515FB Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 173IYm0b160946; Tue, 3 Aug 2021 14:35:45 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a73420jx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Aug 2021 14:35:45 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 173IZ155161973; Tue, 3 Aug 2021 14:35:45 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a73420jww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Aug 2021 14:35:45 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 173IXgQF022643; Tue, 3 Aug 2021 18:35:44 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma02dal.us.ibm.com with ESMTP id 3a6j2esyfv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Aug 2021 18:35:44 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 173IZglE48693690 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Aug 2021 18:35:42 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1F1E26E04E; Tue, 3 Aug 2021 18:35:42 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A5AC6E050; Tue, 3 Aug 2021 18:35:39 +0000 (GMT) Received: from lexx (unknown [9.171.49.56]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 3 Aug 2021 18:35:39 +0000 (GMT) Message-ID: <683f058e6cc1c2eb3ebd7a4a6133d969e84fe3e5.camel@vnet.ibm.com> Subject: Re: [PATCH, rs6000] Add ppc64*_gnu_triplet_regexp methods. From: will schmidt To: Tom Tromey , will schmidt via Gdb-patches Cc: Ulrich Weigand , rogerio , Alan Modra Date: Tue, 03 Aug 2021 13:35:37 -0500 In-Reply-To: <877dh8aovl.fsf@tromey.com> References: <877dh8aovl.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: J6ZO4SAszLklbVd0ylnKdbMR2sdYOFcz X-Proofpoint-GUID: JUHSVuyOLA4euh6A7QT_Uqemx-dDML31 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-03_05:2021-08-03, 2021-08-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 malwarescore=0 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=0 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108030118 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 18:35:48 -0000 On Thu, 2021-07-29 at 13:42 -0600, Tom Tromey wrote: > > > > > > ">" == will schmidt via Gdb-patches < > > > > > > gdb-patches@sourceware.org> writes: > > > [PATCH, rs6000] Add ppc64*_gnu_triplet_regexp methods. > > > Hi, > > > Add methods to set the target triplet so we can > > > find the proper gcc when our gcc is named of > > > the form powerpc64{le}--gcc or ppc64{le}--gcc. > > Hi. Thank you for the patch. > I have a few nits, nothing too serious. > > > > gdb/Changelog: > > > yyyy-mm-dd Will Schmidt > > > * gdb/ppc-linux-tdep.c (ppc64le_gnu_triplet_regexp): New > > > function to set triplet. > > > (ppc64_gnu_triplet_regexp): Same. > > > (ppc_linux_init_abi): Conditionally call to set the > > > ppc64 or ppc64le triplets. > > ChangeLog entries aren't needed any more. ok. :-) > > > > +static const char * > > > +ppc64le_gnu_triplet_regexp (struct gdbarch *gdbarch) > > > +{ > > > + return "p(ower)*pc64le?"; > > Indentation looks off. Ok. I'm usually careful with whitespace, but I may have hosed something up when pasting into the email. I'll double-check. > Also I would use "?" rather than "*" in this regexp. > And, is the "e" really optional? Seems a bit weird. Correct, the 'e' is not optional. My bad. Thanks for the review. I'll refresh, retest, repost. Thanks -Will > > > > +static const char * > > > +ppc64_gnu_triplet_regexp (struct gdbarch *gdbarch) > > > +{ > > > + return "p(ower)*pc64?"; > > Same comments. > > > > + /* Set compiler triplet. */ > > > + if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_LITTLE) > > > + set_gdbarch_gnu_triplet_regexp (gdbarch, > > > ppc64le_gnu_triplet_regexp); > > > + else > > > + set_gdbarch_gnu_triplet_regexp (gdbarch, > > > ppc64_gnu_triplet_regexp); > > Indentation looks off here as well. > > Tom