From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 4269838582A3 for ; Wed, 23 Nov 2022 23:33:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4269838582A3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ANKTSTc014185 for ; Wed, 23 Nov 2022 23:33:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=4wzvWLqRr7VKyW8YPWpoLvMlQfL7GV5t//xhpWRmdlg=; b=Ns+Qosoxkm0Qm3ye9HR97BNdygXrqABhel1rzjx17vWUk8V54G0cUxnJ0FMAGDVd7lzL 7F8yRT2Y4P1zAo38jUjwXq8suAeZ+1xHCtnpd3GfMaoRnf+uZvSSPICUwFAxBP9ksfjr 8m06TTyjfF+rR6/RBnt8EDKsgJFas8fG3qZe0WJBqZ6fzqhggD5Rh25XCTKVw5sWkzIM JQ9Ijs7ZWFY5nJ+17Vta4f7NO8fNQK9NlwS8/17WFvxC0d96Agwb+ANaTNSZZULJN5yG kgjMcAqlND5bqQWgYolqigu1tJZWVas6BQXP3bT9ISAryswMIRbr2nKbJ5yHSWd6i/Rn Ig== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m1153aake-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 23 Nov 2022 23:33:48 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2ANNRn0b005560 for ; Wed, 23 Nov 2022 23:33:47 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m1153aak1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 23:33:47 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2ANNJiEP030860; Wed, 23 Nov 2022 23:33:46 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma02dal.us.ibm.com with ESMTP id 3kxpsaneds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Nov 2022 23:33:46 +0000 Received: from smtpav03.wdc07v.mail.ibm.com ([9.208.128.112]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2ANNXjsc2622194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Nov 2022 23:33:45 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EC62B5805A; Wed, 23 Nov 2022 23:33:44 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5076B5805C; Wed, 23 Nov 2022 23:33:44 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.52.7]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 23 Nov 2022 23:33:44 +0000 (GMT) Message-ID: <684f43f42260a86e021ef9b484c5c732f2604db3.camel@us.ibm.com> Subject: Re: [PATCH] PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp From: Carl Love To: Ulrich Weigand , "gdb-patches@sourceware.org" , "blarsen@redhat.com" Cc: "will_schmidt@vnet.ibm.com" , cel@us.ibm.com Date: Wed, 23 Nov 2022 15:33:43 -0800 In-Reply-To: <75b124722aa20466d5044fa115b679b61ff83010.camel@de.ibm.com> References: <69b2451b-1baf-8bd4-25dd-a1b46963981f@redhat.com> <75b124722aa20466d5044fa115b679b61ff83010.camel@de.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: -FnICXWiP3y4ImjgaIcUHpeUE_PCkWGZ X-Proofpoint-GUID: UuLpbOPOARzGnb2SM2nwVQX41ISauO51 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-23_13,2022-11-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=528 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211230174 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2022-11-23 at 17:56 +0000, Ulrich Weigand wrote: > Carl Love wrote: > > > I have updated the patch, below. If you could take a quick look > > and > > make sure it works on your system that would be great. Assuming it > > is > > OK, hopefully we can get a maintainer to bless it and we will get > > the > > patch committed. > > This approach makes sense to me. The one thing that may not be > quite optimal is that having finish-reverse-bkpt.exp use the same > source file as finish-reverse.exp starts looking to be more trouble > than it may be worth. > > Would it make sense to create a new finish-reverse-bkpt.c file > that contains just the stripped-down test case (using the function > pointer) required to do the "break *callee" test? > > Same for next-reverse-bpkt-over-sr.exp vs. step-reverse.c. Splitting the tests off to their own source file would be fine. I will work on that. Thanks for the review. Carl