From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Constify ada_encode return type
Date: Fri, 2 Oct 2020 17:51:13 -0400 [thread overview]
Message-ID: <6864fd19-d99f-7066-1eef-7dbbf6f2d84f@simark.ca> (raw)
In-Reply-To: <20201002202604.1517475-2-tromey@adacore.com>
On 2020-10-02 4:26 p.m., Tom Tromey wrote:
> Callers of ada_encode don't ever modify the result, and also don't own
> it -- it is owned by a static buffer in ada_encode_1. This patch
> changes ada_encode to return a const char *, which I feel is somewhat
> clearer.
>
> gdb/ChangeLog
> 2020-10-02 Tom Tromey <tromey@adacore.com>
>
> * ada-lang.h (ada_encode): Constify result.
> * ada-lang.c (ada_encode): Constify result.
> (ada_encode_1): Constify result.
> ---
> gdb/ChangeLog | 6 ++++++
> gdb/ada-exp.y | 6 +++---
> gdb/ada-lang.c | 4 ++--
> gdb/ada-lang.h | 2 +-
> 4 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y
> index 57d89b01fec..61d8df9df48 100644
> --- a/gdb/ada-exp.y
> +++ b/gdb/ada-exp.y
> @@ -1201,9 +1201,9 @@ write_var_or_type (struct parser_state *par_state,
> if (block == NULL)
> block = par_state->expression_context_block;
>
> - encoded_name = ada_encode (name0.ptr);
> - name_len = strlen (encoded_name);
> - encoded_name = obstack_strndup (&temp_parse_space, encoded_name, name_len);
> + const char *temp_name = ada_encode (name0.ptr);
> + name_len = strlen (temp_name);
> + encoded_name = obstack_strndup (&temp_parse_space, temp_name, name_len);
Could this be further simplified to:
encoded_name = obstack_strdup (&temp_parse_space, ada_encode (name0.ptr));
?
In any case, this LGTM.
Simon
next prev parent reply other threads:[~2020-10-02 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 20:26 [PATCH 0/2] ada_encode rewrites Tom Tromey
2020-10-02 20:26 ` [PATCH 1/2] Constify ada_encode return type Tom Tromey
2020-10-02 21:51 ` Simon Marchi [this message]
2020-10-07 18:26 ` Tom Tromey
2020-10-02 20:26 ` [PATCH 2/2] Use obstack in ada_encode_1 Tom Tromey
2020-10-02 21:54 ` Simon Marchi
2020-10-07 18:35 ` Tom Tromey
2020-10-07 18:36 ` Simon Marchi
2020-10-09 20:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6864fd19-d99f-7066-1eef-7dbbf6f2d84f@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).