Re: [PATCH 1/2] Constify ada_encode return type

[Simon Marchi <simark@simark.ca>]

On 2020-10-02 4:26 p.m., Tom Tromey wrote:
> Callers of ada_encode don't ever modify the result, and also don't own
> it -- it is owned by a static buffer in ada_encode_1.  This patch
> changes ada_encode to return a const char *, which I feel is somewhat
> clearer.
>
> gdb/ChangeLog
> 2020-10-02  Tom Tromey  <tromey@adacore.com>
>
> 	* ada-lang.h (ada_encode): Constify result.
> 	* ada-lang.c (ada_encode): Constify result.
> 	(ada_encode_1): Constify result.
> ---
>  gdb/ChangeLog  | 6 ++++++
>  gdb/ada-exp.y  | 6 +++---
>  gdb/ada-lang.c | 4 ++--
>  gdb/ada-lang.h | 2 +-
>  4 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y
> index 57d89b01fec..61d8df9df48 100644
> --- a/gdb/ada-exp.y
> +++ b/gdb/ada-exp.y
> @@ -1201,9 +1201,9 @@ write_var_or_type (struct parser_state *par_state,
>    if (block == NULL)
>      block = par_state->expression_context_block;
>
> -  encoded_name = ada_encode (name0.ptr);
> -  name_len = strlen (encoded_name);
> -  encoded_name = obstack_strndup (&temp_parse_space, encoded_name, name_len);
> +  const char *temp_name = ada_encode (name0.ptr);
> +  name_len = strlen (temp_name);
> +  encoded_name = obstack_strndup (&temp_parse_space, temp_name, name_len);

Could this be further simplified to:

  encoded_name = obstack_strdup (&temp_parse_space, ada_encode (name0.ptr));

?

In any case, this LGTM.

Simon