public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix more cases of improper test names
@ 2016-12-09 21:58 Luis Machado
       [not found] ` <CAJvqv7M2NpW0wWQvkZfRSNoohKts4g6by5zmBbYo_TdnPJg6og@mail.gmail.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Luis Machado @ 2016-12-09 21:58 UTC (permalink / raw)
  To: 'gdb-patches@sourceware.org'; +Cc: Markus Metzger

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

I noticed more occurrences of improper test names. The rather 
mechanical, tedious and large patch below addresses, hopefully, most of 
the leftover cases.

As usual, another pair of eyes is welcome to check if i missed something 
or did an invalid substitution. I anticipate it is going to be equally 
tedious to review this. :-)

This patch also fixes the prepare_for_testing calls to pass proper test 
names.

Also, since it is quite a big patch, gdb-patches@... rejected the 
message (more than 400K). Not ideal, but a tarball is attached.

Ok?

[-- Attachment #2: testnames.tar.bz2 --]
[-- Type: application/x-bzip, Size: 39283 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix more cases of improper test names
       [not found] ` <CAJvqv7M2NpW0wWQvkZfRSNoohKts4g6by5zmBbYo_TdnPJg6og@mail.gmail.com>
@ 2016-12-09 23:21   ` Luis Machado
  2016-12-12 14:02     ` Pedro Alves
  0 siblings, 1 reply; 4+ messages in thread
From: Luis Machado @ 2016-12-09 23:21 UTC (permalink / raw)
  To: Pedro Alves; +Cc: Markus T Metzger, GDB Patches

On 12/09/2016 04:10 PM, Pedro Alves wrote:
> Em 09/12/2016 21:58, "Luis Machado" <lgustavo@codesourcery.com
> <mailto:lgustavo@codesourcery.com>> escreveu:
>>
>> I noticed more occurrences of improper test names. The rather
> mechanical, tedious and large patch below addresses, hopefully, most of
> the leftover cases.
>>
>> As usual, another pair of eyes is welcome to check if i missed
> something or did an invalid substitution. I anticipate it is going to be
> equally tedious to review this. :-)
>>
>> This patch also fixes the prepare_for_testing calls to pass proper
> test names.
>>
>> Also, since it is quite a big patch, gdb-patches@... rejected the
> message (more than 400K). Not ideal, but a tarball is attached.
>>
>
> Can you push it as a user branch?
>

Yes. Just need to figure out the proper way to do it (i suppose it is 
documented somewhere).

Are you proposing it simply for review purposes or to be used for 
further testsuite-related changes?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix more cases of improper test names
  2016-12-09 23:21   ` Luis Machado
@ 2016-12-12 14:02     ` Pedro Alves
  2016-12-23 16:57       ` Luis Machado
  0 siblings, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2016-12-12 14:02 UTC (permalink / raw)
  To: Luis Machado; +Cc: Markus T Metzger, GDB Patches

On 12/09/2016 11:20 PM, Luis Machado wrote:
> On 12/09/2016 04:10 PM, Pedro Alves wrote:
>> Em 09/12/2016 21:58, "Luis Machado" <lgustavo@codesourcery.com

>>> Also, since it is quite a big patch, gdb-patches@... rejected the
>> message (more than 400K). Not ideal, but a tarball is attached.
>>>
>>
>> Can you push it as a user branch?
>>
> 
> Yes. Just need to figure out the proper way to do it

Just "git push" to "users/$username/$topic"

> (i suppose it is documented somewhere).

It's maybe somewhere in the wiki.  If it isn't, it should be.

> 
> Are you proposing it simply for review purposes or to be used for
> further testsuite-related changes?

Just simply for review purposes.  But nevermind, I looked at the
patch now, and it looks good to me.

Thanks,
Pedro Alves

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix more cases of improper test names
  2016-12-12 14:02     ` Pedro Alves
@ 2016-12-23 16:57       ` Luis Machado
  0 siblings, 0 replies; 4+ messages in thread
From: Luis Machado @ 2016-12-23 16:57 UTC (permalink / raw)
  To: Pedro Alves; +Cc: Markus T Metzger, GDB Patches

On 12/12/2016 08:01 AM, Pedro Alves wrote:
> On 12/09/2016 11:20 PM, Luis Machado wrote:
>> On 12/09/2016 04:10 PM, Pedro Alves wrote:
>>> Em 09/12/2016 21:58, "Luis Machado" <lgustavo@codesourcery.com
>
>>>> Also, since it is quite a big patch, gdb-patches@... rejected the
>>> message (more than 400K). Not ideal, but a tarball is attached.
>>>>
>>>
>>> Can you push it as a user branch?
>>>
>>
>> Yes. Just need to figure out the proper way to do it
>
> Just "git push" to "users/$username/$topic"
>
>> (i suppose it is documented somewhere).
>
> It's maybe somewhere in the wiki.  If it isn't, it should be.
>
>>
>> Are you proposing it simply for review purposes or to be used for
>> further testsuite-related changes?
>
> Just simply for review purposes.  But nevermind, I looked at the
> patch now, and it looks good to me.
>
> Thanks,
> Pedro Alves
>

Thanks. Pushed as 5b362f04b2a56d446b024027963be52d61f939cb.

I'll play with pushing to branches so i can do it next time i have an 
extensive change.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-12-23 16:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-09 21:58 [PATCH] Fix more cases of improper test names Luis Machado
     [not found] ` <CAJvqv7M2NpW0wWQvkZfRSNoohKts4g6by5zmBbYo_TdnPJg6og@mail.gmail.com>
2016-12-09 23:21   ` Luis Machado
2016-12-12 14:02     ` Pedro Alves
2016-12-23 16:57       ` Luis Machado

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).