public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Remove relational operators from common/offset-type.h
Date: Tue, 30 Oct 2018 03:17:00 -0000	[thread overview]
Message-ID: <692dbc7e4c7e6f1f6ceccf9fb5711880@polymtl.ca> (raw)
In-Reply-To: <20181029211401.21602-1-sergiodj@redhat.com>

On 2018-10-29 17:14, Sergio Durigan Junior wrote:
> This patch is a follow-up of:
> 
>   https://sourceware.org/ml/gdb-patches/2018-10/msg00601.html
> 
> It removes the declaration of the relational operators for
> common/offset-type.h.  As it turns out, these overloads are not being
> used when a new offset type is declared, because, according to Pedro
> Alves:
> 
>   I think the functions aren't called because they are templates, and
>   thus the built-in (non-template) versions take precedence.  If you
>   make them non-templates, then they should be called.  But, the
>   built-ins are fine, so yeah, we can just remove the custom
>   definitions.
> 
> The patch also adjusts the comments on the code.
> 
> No regressions introduced.
> 
> gdb/ChangeLog:
> 2018-10-29  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	* common/offset-type.h (DEFINE_OFFSET_REL_OP): Delete.
> 	Adjust comments.

Thanks, LGTM.

Simon

  reply	other threads:[~2018-10-30  3:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 21:10 [PATCH] Fix thinko on common/offset-type.h (compare 'lhs' against 'rhs') Sergio Durigan Junior
2018-10-26  4:03 ` Kevin Buettner
2018-10-26 16:30   ` Sergio Durigan Junior
2018-10-26 16:08 ` Simon Marchi
2018-10-26 16:29   ` Sergio Durigan Junior
2018-10-26 18:23     ` Simon Marchi
2018-10-29 20:11       ` Pedro Alves
2018-10-29 20:14         ` Pedro Alves
2018-10-29 21:14 ` [PATCH] Remove relational operators from common/offset-type.h Sergio Durigan Junior
2018-10-30  3:17   ` Simon Marchi [this message]
2018-10-30  3:49     ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=692dbc7e4c7e6f1f6ceccf9fb5711880@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).