From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119906 invoked by alias); 30 Oct 2018 03:17:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119896 invoked by uid 89); 30 Oct 2018 03:17:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 03:17:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9U3HeU9026665 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 29 Oct 2018 23:17:44 -0400 Received: by simark.ca (Postfix, from userid 112) id F03D41EA6F; Mon, 29 Oct 2018 23:17:39 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 64ACB1E870; Mon, 29 Oct 2018 23:17:37 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 30 Oct 2018 03:17:00 -0000 From: Simon Marchi To: Sergio Durigan Junior Cc: GDB Patches , Pedro Alves Subject: Re: [PATCH] Remove relational operators from common/offset-type.h In-Reply-To: <20181029211401.21602-1-sergiodj@redhat.com> References: <20181025211008.12164-1-sergiodj@redhat.com> <20181029211401.21602-1-sergiodj@redhat.com> Message-ID: <692dbc7e4c7e6f1f6ceccf9fb5711880@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00705.txt.bz2 On 2018-10-29 17:14, Sergio Durigan Junior wrote: > This patch is a follow-up of: > > https://sourceware.org/ml/gdb-patches/2018-10/msg00601.html > > It removes the declaration of the relational operators for > common/offset-type.h. As it turns out, these overloads are not being > used when a new offset type is declared, because, according to Pedro > Alves: > > I think the functions aren't called because they are templates, and > thus the built-in (non-template) versions take precedence. If you > make them non-templates, then they should be called. But, the > built-ins are fine, so yeah, we can just remove the custom > definitions. > > The patch also adjusts the comments on the code. > > No regressions introduced. > > gdb/ChangeLog: > 2018-10-29 Sergio Durigan Junior > > * common/offset-type.h (DEFINE_OFFSET_REL_OP): Delete. > Adjust comments. Thanks, LGTM. Simon