Re: [PATCH v3 1/5] sim: Remove self-assignments

[Tsukasa OI <research_trasio@irq.a4lg.com>]

On 2022/10/11 23:21, Andrew Burgess wrote:
> Tsukasa OI <research_trasio@irq.a4lg.com> writes:
> 
>> Clang generates a warning if there is a redundant self-assignment
>> ("-Wself-assign").  On the default configuration, it causes a build failure
>> (unless "--disable-werror" is specified).
>>
>> This commit removes two redundant self-assignments.
> 
> I pushed this patch, but I found a couple more of these in ppc/tree.c
> which I included in this commit.
> 
> Thanks,
> Andrew

My another (upcoming) patchset included exact changes to sim/ppc/tree.c
but thanks for adding it anyway.

Thanks,
Tsukasa

> 
> ---
> 
> commit 5294d882ebb5b10f8a246f2c51ffef05622ef16c
> Author: Tsukasa OI <research_trasio@irq.a4lg.com>
> Date:   Sun Sep 25 08:42:02 2022 +0000
> 
>     sim: Remove self-assignments
>     
>     Clang generates a warning if there is a redundant self-assignment
>     ("-Wself-assign").  On the default configuration, it causes a build failure
>     (unless "--disable-werror" is specified).
>     
>     This commit removes redundant self-assignments from two files.
> 
> diff --git a/sim/common/hw-tree.c b/sim/common/hw-tree.c
> index 56319333d76..8bb5ac77545 100644
> --- a/sim/common/hw-tree.c
> +++ b/sim/common/hw-tree.c
> @@ -335,7 +335,6 @@ split_find_device (struct hw *current,
>        else if (strncmp (spec->path, "./", strlen ("./")) == 0)
>  	{
>  	  /* cd ./... */
> -	  current = current;
>  	  spec->path += strlen ("./");
>  	}
>        else if (strncmp (spec->path, "../", strlen ("../")) == 0)
> @@ -348,7 +347,6 @@ split_find_device (struct hw *current,
>        else if (strcmp (spec->path, ".") == 0)
>  	{
>  	  /* cd . */
> -	  current = current;
>  	  spec->path += strlen (".");
>  	}
>        else if (strcmp (spec->path, "..") == 0)
> diff --git a/sim/ppc/tree.c b/sim/ppc/tree.c
> index 6d20665505e..05532bb47ee 100644
> --- a/sim/ppc/tree.c
> +++ b/sim/ppc/tree.c
> @@ -306,7 +306,6 @@ split_find_device(device *current,
>      }
>      else if (strncmp(spec->path, "./", strlen("./")) == 0) {
>        /* cd ./... */
> -      current = current;
>        spec->path += strlen("./");
>      }
>      else if (strncmp(spec->path, "../", strlen("../")) == 0) {
> @@ -317,7 +316,6 @@ split_find_device(device *current,
>      }
>      else if (strcmp(spec->path, ".") == 0) {
>        /* cd . */
> -      current = current;
>        spec->path += strlen(".");
>      }
>      else if (strcmp(spec->path, "..") == 0) {
>