From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 668F33858415 for ; Tue, 7 Sep 2021 08:53:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 668F33858415 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 88CC921FDF; Tue, 7 Sep 2021 08:52:59 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 7048912FF9; Tue, 7 Sep 2021 08:52:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id Jc5BGmsoN2GEJwAAGKfGzw (envelope-from ); Tue, 07 Sep 2021 08:52:59 +0000 Subject: Re: [PATCH][gdb/testsuite] Simplify gdb.dwarf2/locexpr-data-member-location.exp From: Tom de Vries To: gdb-patches@sourceware.org References: <20210905063948.GA22464@delia> Message-ID: <69503e50-69c7-10ab-6eda-a2a1cda600e4@suse.de> Date: Tue, 7 Sep 2021 10:52:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210905063948.GA22464@delia> Content-Type: multipart/mixed; boundary="------------C0778CD9EA35B07233007DBE" Content-Language: en-US X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 08:53:01 -0000 This is a multi-part message in MIME format. --------------C0778CD9EA35B07233007DBE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 9/5/21 8:39 AM, Tom de Vries wrote: > Avoid this by simplify the test-case to trigger the same assert using the file > command instead. FTR, after the other commits this is what remains. At this point, I don't see a pressing reason for why this should be committed. But perhaps somebody else does. Thanks, - Tom --------------C0778CD9EA35B07233007DBE Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Simplify-gdb.dwarf2-locexpr-data-member-location.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-gdb-testsuite-Simplify-gdb.dwarf2-locexpr-data-member-l"; filename*1="ocation.exp.patch" [gdb/testsuite] Simplify gdb.dwarf2/locexpr-data-member-location.exp When reverting commit 5a20fadc841 the test-case gdb.dwarf2/locexpr-data-member-location.exp runs into an internal-error. Simplify the test-case by triggering the internal-error using gdb_unload instead of runto "bar". Tested on x86_64-linux. --- gdb/testsuite/gdb.dwarf2/locexpr-data-member-location.exp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.dwarf2/locexpr-data-member-location.exp b/gdb/testsuite/gdb.dwarf2/locexpr-data-member-location.exp index 1f70e6a34bd..98f9270d7bb 100644 --- a/gdb/testsuite/gdb.dwarf2/locexpr-data-member-location.exp +++ b/gdb/testsuite/gdb.dwarf2/locexpr-data-member-location.exp @@ -40,7 +40,7 @@ # purging of shared objects. # # 3) After performing some simple gdb commands, the program is -# run again. In the course of running the objfile destructor +# discarded. In the course of running the objfile destructor # associated with the shared object, values are preserved # along with their types. As noted earlier, it was during # the recursive type copy that the bug was observed. @@ -342,8 +342,7 @@ gdb_test "step" "bar \\(.*" "step into bar" # We don't want a clean restart here since that will be too clean. # The original reproducer for PR28030 set a breakpoint in the shared -# library and then restarted via "run". The command below does roughly -# the same thing. It's at this step that an internal error would -# occur for PR28030. The "message" argument tells runto to turn on -# the printing of PASSes while runto is doing its job. -runto "bar" message +# library and then restarted via "run". The command below is more minimal: +# it discards executable file and symbol table. It's at the latter step +# that an internal error would occur for PR28030. +gdb_unload --------------C0778CD9EA35B07233007DBE--