From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 49EE33959C27 for ; Tue, 19 May 2020 17:22:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 49EE33959C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C4D1E1E79B; Tue, 19 May 2020 13:22:35 -0400 (EDT) Subject: Re: [PATCH v4 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board To: Tom de Vries , Michael Weghorn , gdb-patches@sourceware.org Cc: Simon Marchi References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200513094758.523845-1-m.weghorn@posteo.de> <20200513094758.523845-8-m.weghorn@posteo.de> <55eba66f-4c1c-def8-3ea8-894a29fbe66c@simark.ca> From: Simon Marchi Message-ID: <6970f13d-8044-f4bd-ba2b-b43b3467272b@simark.ca> Date: Tue, 19 May 2020 13:22:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <55eba66f-4c1c-def8-3ea8-894a29fbe66c@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 17:22:37 -0000 On 2020-05-19 1:11 p.m., Simon Marchi wrote: > On 2020-05-15 1:29 p.m., Tom de Vries wrote: >> The curly braces are what you get when you directly convert a list of >> strings into a string. >> >> If we do the conversion ourselves, we get the desired outcome: >> ... >> $ cat test.tcl >> #!/usr/bin/tclsh >> >> set args [list hello "with spaces" world] >> >> proc string_list_to_string_with_quotes { args } { >> set s "" >> foreach arg $args { >> set s "$s \"$arg\"" >> } >> return $s >> } >> >> set args_str [string_list_to_string_with_quotes {*}$args] >> puts "run $args_str" >> $ ./test.tcl >> run "hello" "with spaces" "world" >> ... >> >> And we can use the normal "args" rather than the inferior_args, as long >> as we take care to pass the args from one varargs function to another >> using '{*}$args'. > > I'm fine with both ways, do you have a preference? > > Simon > In fact, I think I'd rather not use "args", because that would make it more difficult to add other parameters in the future. So I'd keep "inferior_args", although we can make it accept a list instead of a string, and apply the treatment you have shown above. Or, I like the procedures that accept optional arguments using shell-like switches, so we could do: set inferior_args [list a b c] gdb_run_cmd -inferior-args $inferior_args This is untested, I always forget how tcl converts between strings and lists exactly, but you should see the point. That makes it easier to add other parameters in the future. Simon