From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 0EA153858429 for ; Tue, 27 Feb 2024 09:36:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EA153858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0EA153858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709026586; cv=none; b=hP3WwJPnl5VH+txAQ6KAAgDbcRHhmmBdzEJEwRXEsNGvRkR+jwN3SZB/zqm2tVl0xhBSXWpSlOqMIieWV4XGF4jNsfXEA54yS3t6irCuDaQT+M+yqwuzUGe+6iyVPcXPBU1/dvuh8q72lvO+/cMVNpSHDKQgR5HaXzlsCcLyYjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709026586; c=relaxed/simple; bh=rCUBLwfRQHbe3xPsgiNJzuDaXmXMDLA5IcK+cj6D0kY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=TBA8ocR37sowXQqZt6YW4cjsQP1rNTz7NqJk1rG+JQopwkL7LJ0CfjU9efBN2iLjyEfC2AVb3B1pUp/W3I4dwSaOru3SWKLr3P/L3+VswIXasrsoK0Gq95ovkFAgqpxtPFi6gWZk4p6x6xSW2BfWGLR6VTmXEWM/2Vx74qhDptA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0E1D822050; Tue, 27 Feb 2024 09:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709026583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8bK3Qobnpe1bhU0t2dxVzG+9FuQW50dcjjxnzhbds0=; b=sYtGbFtYFXccvlLeZJtwIbvM1hpxaODu45gz/SMqAMLQNsvH85Fd53plZRWb4/n8EoiVYS aqKd9NXKMmX7U12+WMo0QEVhqOjbQ01Hj2iWt/5+tlppab2lwtQxX+/Ef9RpsPSZNTA6/T KJoQUHcSdmhG63ddIG1ENhX+UU3xygU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709026583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8bK3Qobnpe1bhU0t2dxVzG+9FuQW50dcjjxnzhbds0=; b=smch96Dtd/GIFwkIp3fXsI7iN3eOpqHlDMGki461Oe4s70ZdtKH7rNf79VJOO2D0chvFJh SjBJvoDlolnikFCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709026582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8bK3Qobnpe1bhU0t2dxVzG+9FuQW50dcjjxnzhbds0=; b=vMI6GBGO2h9vo93RCrEdp74v2OiUxi4DBAz5NbaRa5/BRVbAORPN1wW2iAeLPnjv6BSI5C SFIYeLVOL2vVIzF1nywcL1hzoOrKwdU04XhFYLnf8BfKhXyMtdXuLi2JtZjw9HT62ldYzZ n8L9AsHgZRsZEy8DkVAOoHxtV9nSyKI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709026582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8bK3Qobnpe1bhU0t2dxVzG+9FuQW50dcjjxnzhbds0=; b=YzXNv08LKNTyohWGC6pG4pG2buvKVTfaMrXlKG3idfRk80iFbe8QHEL+Kufa7cRt4xzOjx dQfVu0y125CKBrCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ECBC413A67; Tue, 27 Feb 2024 09:36:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0KKlNxWt3WUVdAAAD6G6ig (envelope-from ); Tue, 27 Feb 2024 09:36:21 +0000 Message-ID: <69790895-449e-4c7f-8d1c-20e53e26490d@suse.de> Date: Tue, 27 Feb 2024 10:36:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] Use the .py file in gdb.dap/pause.exp Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240220-py-simple-exc-v3-0-a2825caa4b74@adacore.com> <20240220-py-simple-exc-v3-5-a2825caa4b74@adacore.com> From: Tom de Vries In-Reply-To: <20240220-py-simple-exc-v3-5-a2825caa4b74@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vMI6GBGO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YzXNv08L X-Spamd-Result: default: False [-2.78 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.48)[97.64%]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 0E1D822050 X-Spam-Level: X-Spam-Score: -2.78 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/24 20:46, Tom Tromey wrote: > Tom de Vries pointed out that the gdb.dap/pause.exp test writes a > Python file but then does not use it. This patch corrects the > oversight. > LGTM. Reviewed-By: Tom de Vries Thanks, - Tom > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31354 > --- > gdb/testsuite/gdb.dap/pause.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.dap/pause.exp b/gdb/testsuite/gdb.dap/pause.exp > index 4d13dadd3ad..9038d0f037f 100644 > --- a/gdb/testsuite/gdb.dap/pause.exp > +++ b/gdb/testsuite/gdb.dap/pause.exp > @@ -134,7 +134,7 @@ dap_read_response cancel $cancel_id > # does not continue the inferior) can be canceled. > # > > -write_file py "while True:\n pass" > +set gdbfile [write_file py "while True:\n pass"] > set cont_id [dap_send_request evaluate \ > [format {o expression [s "source %s"] context [s repl]} \ > $gdbfile]] >