From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 0604C3858C53 for ; Wed, 21 Feb 2024 13:35:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0604C3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0604C3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708522511; cv=none; b=pVu2+VZK7mdm4LmcB3jBTYSXvufdJGHQ0J0wnnNRlhN6EfvFXV2tMFMQrkdTSzL0wMnV5bNFiK2LKxyPQaHdkuqX7bkX2kz2IOyNAnG1Qx3LMQ6882JpGVy13dfz9kOVFqL417dil6VKkwZuClwWtA/CHkjVjAiDhqmTIEknQbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708522511; c=relaxed/simple; bh=7A5AQVGlz/Mzd8ZrzXT2otITXfiVU5pDCoNaCsRpbQw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=OKeaDcYf0Hl5AHhu+NQBeyqfiVaKFk1az5qCt2Mt3+9BuGp4NVbVvoNpXtkeK/EAWNqsvapfio3ppf9iTCWWOsJDpcjPdMvKfMAqZwG/bymnUlF9gxcl2FY6R+GMbO6tJQo1pq46M7LBHJ+4Rf5392kxwrQXnt1deuYvRxQZvi8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0362D1FB5A; Wed, 21 Feb 2024 13:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708522509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3y1ibIC5BSSgC1gJKfpuRLdlNRZpTvFzFnWmJ4zfO8k=; b=el/IYfFOJe34Wf9zhJsO5E3HgMoxinTGlVLGGIBzpMJjjLaR1qV+W12U39I6TWFyBtCrgG QjQxbIkgZIkaZQJjREeaYAtbVdmpj89ES8KJ4xtDQkpp9ROLaFi3z7XKdTR70lZXnE0M/8 LjMoprcVsYXwRuGEbfmYvHOB9xjsDvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708522509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3y1ibIC5BSSgC1gJKfpuRLdlNRZpTvFzFnWmJ4zfO8k=; b=C5rRIO7Rp7CEyttaNOBfmG1imZfgjA37hsNkNlluCnzoxrT5B7TLuyoGkWhg01f4oi6+Al 8E6ZchFA+6BtmJDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708522509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3y1ibIC5BSSgC1gJKfpuRLdlNRZpTvFzFnWmJ4zfO8k=; b=el/IYfFOJe34Wf9zhJsO5E3HgMoxinTGlVLGGIBzpMJjjLaR1qV+W12U39I6TWFyBtCrgG QjQxbIkgZIkaZQJjREeaYAtbVdmpj89ES8KJ4xtDQkpp9ROLaFi3z7XKdTR70lZXnE0M/8 LjMoprcVsYXwRuGEbfmYvHOB9xjsDvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708522509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3y1ibIC5BSSgC1gJKfpuRLdlNRZpTvFzFnWmJ4zfO8k=; b=C5rRIO7Rp7CEyttaNOBfmG1imZfgjA37hsNkNlluCnzoxrT5B7TLuyoGkWhg01f4oi6+Al 8E6ZchFA+6BtmJDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E2FFE139D0; Wed, 21 Feb 2024 13:35:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oBJ9NAz81WU7dQAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 13:35:08 +0000 Message-ID: <6984cd84-1b8e-44a8-98b9-0c6ed851d5c6@suse.de> Date: Wed, 21 Feb 2024 14:35:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] [gdb/dap] Join JSON reader and writer threads with DAP thread Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240219082341.21313-1-tdevries@suse.de> <20240219082341.21313-7-tdevries@suse.de> <87sf1m29cm.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87sf1m29cm.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="el/IYfFO"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=C5rRIO7R X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.60 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.10)[95.66%]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Spam-Score: -3.60 X-Rspamd-Queue-Id: 0362D1FB5A X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/24 21:01, Tom Tromey wrote: > Tom> While we're at it, do the same for the JSON reader thread. > > I've been thinking about this and I am no longer sure it's ok to wait > for the reader thread. > > I don't think DAP requires that the client shut down the pipe on exit. > It only requires sending the request. > > So I tend to think gdb ought to exit when requested and not wait for the > reader thread. Committed with that bit dropped. Thanks, - Tom