From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3E6223858D37 for ; Tue, 21 Nov 2023 12:52:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E6223858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E6223858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700571163; cv=none; b=VzxngKUmQVLojXNiRdsIei2Bb6niA8SaC/285LGuPRWQO02m51GMI4lUw5arB4RdiXcJTEIWqzTSQJZxpxX58jw0MP5kdrhahgAQv03xy1Vw1Pp7K9N/DQ3OZ7P4LuxNO1suEV25oIC8rDnal3ax89hKvocSbtR45+ATQM2LlRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700571163; c=relaxed/simple; bh=/D4GijK643lQkQtwX+gqJGoU/845HQp3rdigxfw4Cxk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YmoTOSpcgo2FFuscsAxWGXtyBZd6Erz3exD8jbxT111vMRCyzsvnJwykcsEdvES891x4kvyYo44mgR/r8WoY5CBlo8tWMfxs/pm20DFUctB5Gx6RDAAl3Ooi3oN1AVhajPGy8ac7SDGC+55cCYD5wdSP8wMlG28eZhc12X/CAAA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700571161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aBAYZf0NA9xO3M81j5QjPuu2y8GAJx8nUu3MKVbAHVg=; b=OVMfszQZAcTlK/MfzRIRfTd9DEz0S9bE8k9kZq+MQZuitHMr0hzHcryiroXdqcfLRmQqRt GDDSE9qSVsHA7MKc3aaJT2YrQe+Iv2buCGPKTGUHGpymBAXWbhXzqiTt/drBioCxyy7vDg Oeqbijn/nkTTmc71YhWCCOO0Hzq8v9g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-ggABtFrPOEq0-C9qo6vJLg-1; Tue, 21 Nov 2023 07:52:40 -0500 X-MC-Unique: ggABtFrPOEq0-C9qo6vJLg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40853e14f16so18539025e9.1 for ; Tue, 21 Nov 2023 04:52:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700571158; x=1701175958; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aBAYZf0NA9xO3M81j5QjPuu2y8GAJx8nUu3MKVbAHVg=; b=C2A3qbaRwRmwH9q29eUOs2dYkH4EtcZ5pRLjpk+NNNyet2Abh9C3IhQQpZZs2T4Da+ YCowVaSVezeXDlycZaJSJrzCxYd6zpzTgqHmsnvT3T7bAjOfUF4pZorXcbnfO0vz1br1 Kq7H+t37tyMU6oEJZYvLgwXBYkIumCjMGr43744sG5DefNAy9LjfFsNecVptuE5NIFdl ccfD+J/E5yGNgiJ5i/y4wLTLA8UitP2SooKmeZdqnIV2RodvJd4iYDCDi8XJi6xDk+C9 JuLwe2UiQ7pBt2iH9c+OK+O2qRUF6lZZr48iD6mPAfn4/0oGkc33GQr+3eNOViiaJNNo 0iYQ== X-Gm-Message-State: AOJu0Yyr2KiTtp7+lHKrPxY80DQdzO2WOM6vcsX2WN9i1kG3w8H6Ui9N US9zEPSjZsa0513slj4ZOX7ligmVyJFEk6Ipogla4bFZjiIg6HOSHJK0k6uOKJBwycqjbbaPZhc Cg98ZfdlTxGVrEhaBO6eblQzTdPJNug== X-Received: by 2002:a05:6000:1192:b0:331:3426:4c2c with SMTP id g18-20020a056000119200b0033134264c2cmr6778961wrx.41.1700571158717; Tue, 21 Nov 2023 04:52:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5IIxWPGpZpP9xxiihtKYoMgTCXzgUu93gBjR5AtAXMpcrNgh0J+z96rc1uQevZZzt26D2ow== X-Received: by 2002:a05:6000:1192:b0:331:3426:4c2c with SMTP id g18-20020a056000119200b0033134264c2cmr6778950wrx.41.1700571158362; Tue, 21 Nov 2023 04:52:38 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id v11-20020adfe28b000000b0032d09f7a713sm14424044wri.18.2023.11.21.04.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Nov 2023 04:52:37 -0800 (PST) Message-ID: <69c3cefe-78ed-8d03-f1b4-acd7fee3fe1a@redhat.com> Date: Tue, 21 Nov 2023 13:52:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] Fix hardware watchpoints in replay mode To: Hannes Domani , "gdb-patches@sourceware.org" References: <20230914162732.2077-1-ssbssa.ref@yahoo.de> <20230914162732.2077-1-ssbssa@yahoo.de> <05d3b3e1-fb3c-4a1d-c5c1-75975c2af367@redhat.com> <175805758.9196163.1700495962988@mail.yahoo.com> From: Guinevere Larsen In-Reply-To: <175805758.9196163.1700495962988@mail.yahoo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/11/2023 16:59, Hannes Domani wrote: > Am Montag, 20. November 2023, 14:09:34 MEZ hat Guinevere Larsen Folgendes geschrieben: > >> On 14/09/2023 18:27, Hannes Domani via Gdb-patches wrote: >>> Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 >>> caused a regression that meant hardware watchpoint stops would not >>> trigger in reverse execution or replay mode.  This was documented in >>> PR breakpoints/21969. >>> The problem is that record_check_stopped_by_breakpoint always overwrites >>> record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT >>> value which would be checked afterwards. >>> >>> This commit fixes that by checking if record_full_stop_reason is >>> TARGET_STOPPED_BY_BREAKPOINT and, if so, not overriding it. >>> >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=21969 >>> --- >> I have sent a review to this patch. Your spam filter must have catched >> it or something similar. If you can't find it, here's the link for the >> public inbox: >> https://inbox.sourceware.org/gdb-patches/2eb65a2d-aa80-5930-3033-bfd82baa2ed9@redhat.com/ > I saw that, but it doesn't really make clear what I should do now. > And from what I can remember of our discussion on IRC, you wanted to wait if Pedro had anything to add. > Ah right, sorry, this last month has been pretty hectic, our conversation completely slipped my mind. I took a second, long look at record_check_stopped_by_breakpoint and convinced myself, I don't see why it should overwrite the reason if gdb is not stopped at a watchpoint. I would say send in a v3 with that solution instead, CC Pedro, and I'll give some time for him to react before approving the changes. Also, the changes you made to gdb.reverse/watch-reverse.exp should also be made on gdb.reverse/watch-precsave.exp, since it has the same problem that you identified with watch-reverse. -- Cheers, Guinevere Larsen She/Her/Hers