public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Matthew Fortune <Matthew.Fortune@imgtec.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH, MIPS] Support shared library debug with MIPS PIE (gdb)
Date: Tue, 23 Jun 2015 15:52:00 -0000	[thread overview]
Message-ID: <6D39441BF12EF246A7ABCE6654B023532117634B@LEMAIL01.le.imgtec.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1506231529530.4489@digraph.polyomino.org.uk>

Joseph Myers <joseph@codesourcery.com> writes:
> On Tue, 23 Jun 2015, Matthew Fortune wrote:
> 
> > Please note that the new DT_MIPS_RLD_MAP2 support will not be enabled unless
> > the host's elf.h header has the new tag defined in it. For cross compiled GDB
> > this may mean hacking the solib-svr4.c file to define the macro until such
> > time as distributions update glibc.
> 
> That doesn't make any sense to me.  Hosts (e.g. MinGW) may not have elf.h
> at all.  GDB should get these definitions from the #include "elf/mips.h"
> already in solib-svr4.c (i.e. from toplevel's include/elf/mips.h).  And so
> there should be no #ifdefs there.

Thanks. I got this twisted owing to the gdbserver using the host elf.h and me
keeping the binutils and GDB patches separate when I should have had the
elf/mips.h changes shared between the two.

I'll send an updated patch with the #ifdefs removed and ensure that binutils
commit precedes the GDB commit when approved.

Matthew

  reply	other threads:[~2015-06-23 15:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 15:23 Matthew Fortune
2015-06-23 15:31 ` Joseph Myers
2015-06-23 15:52   ` Matthew Fortune [this message]
2015-06-26 12:45   ` Matthew Fortune
2015-08-12 10:30     ` Pedro Alves
2015-08-12 13:43       ` Matthew Fortune
2015-08-12 13:59         ` Pedro Alves
2015-07-13 10:21   ` Matthew Fortune

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D39441BF12EF246A7ABCE6654B023532117634B@LEMAIL01.le.imgtec.org \
    --to=matthew.fortune@imgtec.com \
    --cc=gdb-patches@sourceware.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).