From: Bruno Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>,
Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb/testsuite: Improve testing of GDB's completion functions
Date: Mon, 27 Feb 2023 11:03:44 +0100 [thread overview]
Message-ID: <6a15c025-530d-8e9b-6220-563ed95bac06@redhat.com> (raw)
In-Reply-To: <87bklij32o.fsf@tromey.com>
On 24/02/2023 20:06, Tom Tromey wrote:
>>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> Bruno> When looking at some failures of gdb.linespec/cp-completion-aliases.exp,
> Bruno> I noticed that when a completion test will fail, it always fails with a
> Bruno> timeout. This is because most completion tests use gdb_test_multiple
> Bruno> and only add a check for the correct output. This commit adds new
> Bruno> options for both, tab and command completion.
>
> Looks good to me.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
>
Thanks, pushed!
--
Cheers,
Bruno
next prev parent reply other threads:[~2023-02-27 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 9:11 Bruno Larsen
2023-02-24 19:06 ` Tom Tromey
2023-02-27 10:03 ` Bruno Larsen [this message]
2023-07-15 12:13 ` Tom de Vries
2023-07-25 15:40 ` Bruno Larsen
2023-08-15 5:45 ` Tom de Vries
2023-08-15 7:05 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a15c025-530d-8e9b-6220-563ed95bac06@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).