From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id EE1C33858D35 for ; Sun, 19 Jul 2020 15:44:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EE1C33858D35 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 06JFiAGL015831 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 19 Jul 2020 11:44:15 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 06JFiAGL015831 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E19A31E5F9; Sun, 19 Jul 2020 11:44:09 -0400 (EDT) Subject: Re: [PATCH v3 0/9] Handling multiple JITers To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: From: Simon Marchi Message-ID: <6a286e63-2e25-b4f8-f6c8-166c068855af@polymtl.ca> Date: Sun, 19 Jul 2020 11:44:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 19 Jul 2020 15:44:10 +0000 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2020 15:44:21 -0000 On 2020-07-15 4:16 a.m., Tankut Baris Aktemur wrote: > Hi, > > This is v3 of the series originally submitted at > > https://sourceware.org/pipermail/gdb-patches/2020-May/168959.html > > The v2 is at > > https://sourceware.org/pipermail/gdb-patches/2020-June/169539.html > > Upon that revision, Simon Marchi had proposed > > https://sourceware.org/pipermail/gdb-patches/2020-June/169758.html > > The updates in this revision v3 are as follows: > > 1. The patches mentioned by Simon in the link above have been cleaned up. > > 2. The 'jiter_data' and 'jited_data' fields have been added directly > to the objfile struct as per Pedro's suggestion at > https://sourceware.org/pipermail/gdb-patches/2020-June/169796.html > > 3. A final commit addresses Simon's comment of skipping JIT symbol > lookup in an objfile if a lookup was already done and the symbols > were not found. > > Regards. > Baris > > Simon Marchi (7): > gdb/jit: link to jit_objfile_data directly from the objfile struct > gdb/jit: split jit_objfile_data in two > gdb/jit: apply some simplifications and assertions > gdb/jit: move cached_code_address and jit_breakpoint to > jiter_objfile_data > gdb/jit: remove jiter_objfile_data -> objfile back-link > gdb/jit: apply minor cleanup and modernization > gdb/jit: skip jit symbol lookup if already detected the symbols don't > exist > > Tankut Baris Aktemur (2): > gdb/jit: pass the jiter objfile as an argument to jit_event_handler > gdb/jit: enable tracking multiple JITer objfiles > > gdb/breakpoint.c | 3 +- > gdb/jit.c | 357 +++++++------------ > gdb/jit.h | 4 +- > gdb/objfiles.h | 50 +++ > gdb/testsuite/gdb.base/jit-reader-simple.exp | 43 ++- > 5 files changed, 234 insertions(+), 223 deletions(-) The comments I sent on patches 1-3 are all I had to say, at least for now :) Simon