From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150051.outbound.protection.outlook.com [40.107.15.51]) by sourceware.org (Postfix) with ESMTPS id 5AEDD3858C2C for ; Fri, 22 Apr 2022 08:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5AEDD3858C2C Received: from DB6PR07CA0196.eurprd07.prod.outlook.com (2603:10a6:6:42::26) by DB8PR08MB5257.eurprd08.prod.outlook.com (2603:10a6:10:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 22 Apr 2022 08:44:28 +0000 Received: from DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::d0) by DB6PR07CA0196.outlook.office365.com (2603:10a6:6:42::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.6 via Frontend Transport; Fri, 22 Apr 2022 08:44:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT012.mail.protection.outlook.com (10.152.20.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Fri, 22 Apr 2022 08:44:27 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Fri, 22 Apr 2022 08:44:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fec441ad64c3310c X-CR-MTA-TID: 64aa7808 Received: from f89d644ede63.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 995D3E9E-60C3-432A-8933-3940BF27E428.1; Fri, 22 Apr 2022 08:44:21 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f89d644ede63.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Apr 2022 08:44:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DB9QKp5ZNclLj5Tc+NqNH76XdOMGq7vo8zyHjoKX7QJYr0zvOeAMY+7XRLdBlf32hSP0Z3MFOBANCf59UhVuycwZYkzue/tKnuxzzBCYkRV5G8epONXtJc3E6rIqT2WqkaIprauqFGK0g4VA7i4tmO9/8udbAVZUfAE8RaIXgbXDGTHZQH395xzPiwBLrAESGwimWX9lFcvzu2ENGScvljkR66twN0t3ODdVdRWXvGB+6xnAqfKJ8H4EudGwFfvcPwT6YYTQmvoZJbfHi1ICIx8FdEOujkc0TVi8GqLr5zmzmUSzIYnDlpaC/GYiudOCbZ0Qum69B7es/U78viYuQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JhjwLwWvqlmbV0ULv/Ij7iPXjZxc3bzKqXFGPuq8Ao4=; b=kTW8FPdKhWQjGB9zRbQEo5Ru9+9oHE8wqDhEcrCblnArBA3vGPz6yo050hdf0pnDoY6/WKu80WJ9BSdudy/PXOV1gbv41/9Dsy7/914kqZlJ/uADFObujz06dHtmBw+tVvPpdfUKvyqUXry0NRNHXOFhee6EB0whnVQfVAWR4YU7RxDZRplYPE/flckZU7zAzEe7qD9/NAth5k+pzVzy7re8UxpJmpN7n0pntT/93fuPESxOxUepEEREcukE9ahP4FHj8+LP+WbmJH83PcioPJvNLPQVqYeaReucfFlxQFvTSpE8oDkas/QCbE6o0QwTjF++zjNZBfAi0Nyy2bbb1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB6PR0802MB2455.eurprd08.prod.outlook.com (2603:10a6:4:a0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr 2022 08:44:19 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 08:44:19 +0000 Message-ID: <6a9c0045-ed0d-507d-4983-ade393a67e24@arm.com> Date: Fri, 22 Apr 2022 09:44:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH, v2] [AArch64] MTE corefile support Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20220331140343.9047-1-luis.machado@arm.com> <20220421152040.128278-1-luis.machado@arm.com> <83pmlaqvrl.fsf@gnu.org> <83v8v1plkl.fsf@gnu.org> <83tualpkyv.fsf@gnu.org> From: Luis Machado In-Reply-To: <83tualpkyv.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: beb6d3aa-08d4-4867-73bd-08da243c4f93 X-MS-TrafficTypeDiagnostic: DB6PR0802MB2455:EE_|DB5EUR03FT012:EE_|DB8PR08MB5257:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: B92zaHV/5BdgQkdLL/FS33wKF6tJLlYtP30RGcH0+CpTQ190nu5erTsSSn66fPBQhm3xrpypIALe9rRAeYwCQX8RnyoTo2dez0xMH50kKkLi3FXam/m/aAWcYySH/4us9naQLicaNVgijGtvWC63MVLcZN7T7+vfwlkDOGntmhbJh91SefHpUafdr/oQdFKGBzvQnIW878zXnrGwJu7n3h7CaKI8afuPNZLNETj1KCdgqT9gvDocHbvo+Apji+NGqDvj6wA6cMazAAG8G2ANvBouaQdPfgzR3//sGtKp7McJc+8FC8zcJq67kWYdRFrZn8ZjbAjU3eebURU+poJe992I7Aby60Bm+Z0vUGDKB1MRRvttOS7DlAHjSVpJEBKQs/n6Wt1LyCNH+LVAc4vShOm/lRW2g4Lu6eKKVQBkFTgFUJ5bndr0PmIvrm8ApQnqI0f7T85TwaLrPwWq9jUAutcmL52bEsHwSjxITtwTlia+UxxoYrFNXRmb8HCoHVVoc0AEI9cwszFkaCkQul6WkMKOJht9Cg1mUiVlXvaLvr/ebw4bvktu6oot/NGTvdtlFNJb1ttV609eOZXsFrzQXmYYcNuSYadqKa/Gt+rmilTda1vOTqd80PxYMpQSmQBE+BSsrypgUX37NeCmICi+IgblcefWxLMCrl9PowE5W2GrpD+JxCJPCTT4oIf6V2QhqvX2igXNmmkjru5dyVARtQTh4oPJoZTv8qWabz6wqek= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(4326008)(31696002)(6916009)(8676002)(66476007)(508600001)(66946007)(2616005)(53546011)(26005)(6512007)(6506007)(8936002)(38100700002)(86362001)(66556008)(6486002)(31686004)(83380400001)(2906002)(36756003)(44832011)(186003)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2455 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e0acf5b5-c86c-4570-a80d-08da243c4aa2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B8vuv388HgOm/GWJ/IYS9SgI2yxgDyhl0m1FkH1EsNPUzIzcozL72JcbItvCgmsz/LHYmZj3hzX7emitBmqfHQd6kv1dU/APAg9e1vZcrawDt/8zhDpdGJWAjkF2qSpy0dZwXAvRRyU5JYWtWou3VdkxHrNBY8cRkDLP2IiqMu04v61zN9oQTw/N+/qMJ6QZKoEmz684Zxw1uVNS5VzB2UnoYfezMtIfBZ7mjLbKkyY8giPpEYh24u5qOkyV+37XKjQ6bXDJ29FOVGtovukiVOZW7fAOaQThLKQhyK+VXPCCjacqWR7sJWCUeQ0jSCWTh/uA5rSnArWmifDHv3D0leYg0HozPJobs9EL4uC2u0UD8nRP3t5BNocGB78ugZcqM+xlbxHgQBMs16NjR1p3cD4hLI24ukxOkLYH6FGARqShb2KfY1dOCI7KCa6V/YGl5HUnavoQDy0Oohk6ignD+lnUogx9pGyCkuvUPPuGtvrY+Tt2H8ZIQMX+DD24Vg145u/eqgsbD59UWGA8iZlQcUVdDYzRM+q6lqlaH5OK8accmukRzgneHYp2wpZ48Jx660Qhc23Z4yXlRYZFG8F9zzl7JhZn+BnEU75BJgSYjrihEuPoy+ThkO/Br/aMsVsBQdGOczxCAOHCmaIVCsXd913PcSgtbjl3VbeOS9KDKvstnMfvjWbwp3A9ZsvC9oxanoG4yWdNaCxhDjlLivJF7g== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(6486002)(2616005)(336012)(81166007)(508600001)(47076005)(6512007)(83380400001)(186003)(44832011)(316002)(40460700003)(2906002)(8936002)(8676002)(5660300002)(4326008)(6506007)(6862004)(82310400005)(26005)(36860700001)(70206006)(70586007)(31686004)(53546011)(86362001)(356005)(36756003)(31696002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 08:44:27.8047 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: beb6d3aa-08d4-4867-73bd-08da243c4f93 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5257 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 08:44:32 -0000 On 4/22/22 09:43, Eli Zaretskii wrote: >> Authentication-Results-Original: dkim=none (message not signed) >> header.d=none;dmarc=none action=none header.from=arm.com; >> Date: Fri, 22 Apr 2022 09:37:47 +0100 >> Cc: gdb-patches@sourceware.org >> From: Luis Machado >> NoDisclaimer: true >> Original-Authentication-Results: dkim=none (message not signed) >> header.d=none;dmarc=none action=none header.from=arm.com; >> >> On 4/22/22 09:30, Eli Zaretskii wrote: >>>> Date: Fri, 22 Apr 2022 09:12:44 +0100 >>>> Cc: gdb-patches@sourceware.org >>>> From: Luis Machado >>>> >>>>>> *** Changes since GDB 12 >>>>>> >>>>>> +* GDB now supports dumping memory tag data for AArch64 MTE. It also supports >>>>>> + reading memory tag data for AArch64 MTE from core files generated by >>>>>> + the gcore command or the Linux kernel. >>>>>> + >>>>> >>>>> I think this should say something about the significance of this >>>>> feature. Otherwise it is completely unclear why would GDB want to >>>>> support that. >>>>> >>>>> Same comment for the addition to the manual. >>>>> >>>>> Thanks. >>>> >>>> It is a bit short. How about the following additional paragraph? >>>> >>>> "When a process uses memory-mapped pages protected by memory tags (for >>>> example, AArch64 MTE), this additional information will be recorded in >>>> the core file in the event of a crash or if GDB generates a core file >>>> from the current process state. >>>> >>>> The memory tag data will be used so developers can display the memory >>>> tags from a particular memory region, and will also be used to show a >>>> detailed message about a crash that happened due to a memory tag violation." >>> >>> This is fine, but can what's described in the last paragraph be done >>> by GDB commands, or does it require external tools? In the former >>> case, we should mention those GDB commands; in the latter case I'd >>> settle for mentioning the fact that external tools are required. >> >> No external tools are required. GDB already supports displaying memory >> tags automatically if it detects the process is using those. We can >> explicitly mention the 'm' modifier for the x command and the memory-tag >> sub-commands. >> >> Would this be more appropriate for the manual entry? Or do you think it >> makes sense to mention it in the NEWS as well? > > It's okay to only mention that in the manual. NEWS should just say > that GDB can display those tags automatically. > > Thanks. Thanks. I'll update these entries and will submit a v3.