From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by sourceware.org (Postfix) with ESMTPS id 0F78B3858D33 for ; Tue, 14 Mar 2023 19:48:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F78B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2a.google.com with SMTP id m6so4104594qvq.0 for ; Tue, 14 Mar 2023 12:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678823325; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=2iCvVEKeW3o14snYahDQGeVofE/GQn+P8iuuXqWmJfc=; b=O86JCcTA2E8eNLSLbsIi6yNFZwJ0rDFqVJs5U/mDZy0SeTCh1kwYg0WOQ3DTv60fSA 7L8xmI+7sXeATqY80g3P7hhAXOxp2+5pk8pb3A4gcG/pzfCwO3eDrchYqpiJVUUB5FiB XeOx3Z3D43kTYKR2iKTeiuw+dZdpKFyjutO7I4K7VHsZSr6GtDYVd3OtNgXWvy8qn12o 9D+ooUcU779bWsDVbeKMpbQzBbpYu9jyAh26VRNQRr/NUiDUPRCtFRzjGODl7yw9NJ4c D0MU7G3Irv+r/1Y1txpSw1jmqjFinFPsPpK8sXGfnmxqIclA2/CxITZnO4M62mewTkn7 azaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678823325; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2iCvVEKeW3o14snYahDQGeVofE/GQn+P8iuuXqWmJfc=; b=XZ4E33wuCzAHBD6fqxdgk5aCC/SibFmDlGWCi3iLNgEkEJevozctCAie79Z9tTiRFV jrJzdEzkDYOTspLBwcL4yuhUxmygIe2arHZO00nRLjMaQ5vhLMO31f+Tqu7sckazQDQ1 xZcq7av1ShkToGEMqnI+GYLUiy5xEyKJksasGpODnYzK8WIimO4fyFs8zhGp/c3sTfnf 8tlIZPLLSts95U2Musqq+JSpxzxUUInbxeCLU9M6ITe4O9CxqF/Zd3nFvFUQtNQX+PCp oRf0+x8AE8Z7HCGx1h0ohicfB0S381mP+vNF7aOfWz+eKjZUPEgS5XbMVevj632dIKe0 UTQw== X-Gm-Message-State: AO0yUKW2nElnRAB9XZfIGr3sAriCFuDAK5jlmwOMD0KXC/woenfbLDfC sYVbVgxIBUuu14aRgbLmu3Y= X-Google-Smtp-Source: AK7set/TefWBfDqcNNlL+Z0Lw2RebH1/IttlN26t1bsbNA+F7ycXlAhaP0usJwK++05ExUUpMSL1Mg== X-Received: by 2002:a05:622a:1a84:b0:3d2:7950:f790 with SMTP id s4-20020a05622a1a8400b003d27950f790mr5259581qtc.62.1678823325223; Tue, 14 Mar 2023 12:48:45 -0700 (PDT) Received: from [192.168.1.128] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id d9-20020ae9ef09000000b0073ba211e765sm2360584qkg.19.2023.03.14.12.48.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 12:48:44 -0700 (PDT) Subject: Re: [PATCH 2/2] gdb/doc: uniformize wording for GMP and MPFR entries To: Eli Zaretskii Cc: gdb-patches@sourceware.org, apinski@marvell.com References: <20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com> <20230306-doc-require-mpfr-fix-v1-2-8f207504dd3e@gmail.com> <83ttysxvp9.fsf@gnu.org> <83y1nzsfgu.fsf@gnu.org> <83a60fruhx.fsf@gnu.org> From: Philippe Blain Message-ID: <6a9c5a31-5b67-d684-5c57-07b4b1516318@gmail.com> Date: Tue, 14 Mar 2023 15:48:43 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <83a60fruhx.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Eli, Le 2023-03-14 à 15:41, Eli Zaretskii a écrit : >> From: Philippe Blain >> Cc: gdb-patches@sourceware.org, apinski@marvell.com >> Date: Tue, 14 Mar 2023 13:38:08 -0400 >> >> Le 2023-03-14 à 13:12, Philippe Blain a écrit : >>> Hi Eli, >>> >> [...] >>> >>> I guess I was confused by the fact that 'Approved-by' is used here in a different way >>> than in the Git project, where it is an explicit approval >> >> I meant 'Reviewed-by' here, sorry. > > Do they really use Reviewed-by as an approval? _That_ would be > confusing, since the word "review" means just that, it doesn't mean > any approval. > Yes, in the Git project, Reviewd-by is approval, see for example item 3. at https://git-scm.com/docs/SubmittingPatches#sign-off (under "If you like, you can put extra tags at the end"): Reviewed-by:, unlike the other tags, can only be offered by the reviewers themselves when they are completely satisfied with the patch after a detailed analysis. This is in line with what it means for Linux also, as far as I understand [1]. Thanks, Philippe. [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes