From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5FD883858428 for ; Wed, 3 May 2023 16:38:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FD883858428 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.170] (unknown [167.248.160.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F16D81E0D6; Wed, 3 May 2023 12:38:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1683131886; bh=EvNJ5syOdUidGpriDSWQV7/C1RI3jDogBj+28s8IZ7s=; h=Date:Subject:To:References:From:In-Reply-To:From; b=C/2cnnxziTgZ5D+tfWx40rVFfLsiM3miiq5LwvR39HJ4CC3rv+mtGkC+MxV7LBbko WZGxd5Cpprr8e71tLq6E4UkZh7S9gRGQKa7VUjslsDYcVAqvPXoqGIm1MkzNawhI26 jhMcdCx6BUWaIjqP1ymGgiTo4oS/MKux/Yw10Scs= Message-ID: <6aa05767-b4bb-9388-0866-2366dfa61720@simark.ca> Date: Wed, 3 May 2023 12:38:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 08/19] *-linux-nat: Handle null inferior in read_description. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230427210113.45380-1-jhb@FreeBSD.org> <20230427210113.45380-9-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20230427210113.45380-9-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/27/23 17:01, John Baldwin wrote: > Don't invoke ptrace in the target read_description method if there is > not an active inferior to query via ptrace. Instead, use the default > register set for the architecture. Since this fixes a user-visible problem, can you please update the commit message to indicate what this is fixing? If I remember correctly: (gdb) target native Done. Use the "run" command to start a process. (gdb) unset tdesc filename Couldn't get CS register: No such process. And you could include the equivalent in the previous commit (the one that fixes it for fbsd), I guess you get a slightly different error there? It would also be nice to have a test for this, which would ensure that the "unset tdesc filename" command outputs nothing. Simon