From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by sourceware.org (Postfix) with ESMTPS id 54763386F0EC for ; Fri, 24 Jun 2022 15:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54763386F0EC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f41.google.com with SMTP id s1so3522735wra.9 for ; Fri, 24 Jun 2022 08:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=OLwVYhoV0IsdaTniEuWSFV2E+xiqTBFYdrs+x5mKCiQ=; b=AJs+GfE2fj+EXZGIsOULpht3lvNcfrGpvOUIRHV/0I0XQYW3+/Sr4g/ofxlHMgKAYs HD9VuuKRLuXnmKFWobm6IbjIsAxCL83b9klgXBEwYnqXt5ULVC1fw8yi3rViZGSlzAan KOjnz7LXf5rWacPUjbqiLQKXnPcfUKH8+mdA0ySk9cUQ8Ev8uWary0HCLSwt5Bn4EAcw YW1+Z28xYP8AULi3EAVDMX+gf32+hv9TsuZKX+CQ00TsRBAocdYpfTiaQATzydrsdb4J 1gg8i23tkXTBkQZt0dKhyHBdznsZ7dSVT/Ct+cuYfYfQa1NJzmx+IQ6b/7ZRhWfBQAKc oJyA== X-Gm-Message-State: AJIora986H3lusIS+Ag8EPFlbcQfkwh7P3avGfHOSv7gWfnirA4Iq2kI q2fXLH4c6bdbdLrXu0hUQZK1zpuxdKc= X-Google-Smtp-Source: AGRyM1uw1iiuz0J3KJqn50o+EKKcj0ELwKYOJpGWNPlr7EUW0Q75tQMge+fbr9iWhZT7//l3sSTbKQ== X-Received: by 2002:a05:6000:ca:b0:21b:8082:7518 with SMTP id q10-20020a05600000ca00b0021b80827518mr13594162wrx.124.1656083635294; Fri, 24 Jun 2022 08:13:55 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id o14-20020a05600c4fce00b00397122e63b6sm2916534wmq.29.2022.06.24.08.13.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 08:13:54 -0700 (PDT) Message-ID: <6abb48e4-019c-d2c6-5565-3a471249dbfc@palves.net> Date: Fri, 24 Jun 2022 16:13:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] gdb/testsuite: modernize gdb.base/maint.exp Content-Language: en-US To: Andrew Burgess , Bruno Larsen , gdb-patches@sourceware.org References: <87edzic8v1.fsf@redhat.com> <20220621194520.34682-1-blarsen@redhat.com> <87k096b3k5.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87k096b3k5.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 15:13:57 -0000 On 2022-06-24 14:20, Andrew Burgess via Gdb-patches wrote: > You could use just: > > gdb_assert { $seen_command } > > here. Or maybe: > > gdb_assert { $seen_command } $gdb_test_name > > Or possibly even: > > gdb_assert { $seen_command } > pass $gdb_test_name > > I think option #2 would be my pick, but whatever you prefer is fine I think. > I think option #2: gdb_assert { $seen_command } $gdb_test_name is the right one, as it keeps pass/fail balanced if this test ever fails without reaching the prompt regexp match.