From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12898 invoked by alias); 9 May 2018 23:50:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12882 invoked by uid 89); 9 May 2018 23:50:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 23:50:35 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2499D11E113; Wed, 9 May 2018 23:50:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A565A2166BAD; Wed, 9 May 2018 23:50:33 +0000 (UTC) Subject: Re: [RFA v2] Add "continue" response to pager To: Tom Tromey References: <20180425145200.27734-1-tom@tromey.com> <941985b1-5166-44ab-72fe-b0f62d411e2e@redhat.com> <87d0y44iyi.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <6b0962b4-1867-0003-6310-e874ff1df2f3@redhat.com> Date: Thu, 10 May 2018 00:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87d0y44iyi.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00229.txt.bz2 On 05/09/2018 10:28 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> I gave the patch a quick try, and I have to say that it looks a > Pedro> bit odd to me that the pager prompt takes two lines: > > Pedro> ---Type to continue, q to quit, or c to > Pedro> continue without paging--- > > Pedro> I'm wondering whether we can shorten that, to, say: > > Pedro> ---Type for more, q to quit, c to continue without paging--- > > Yeah, I think that would be better. > > The Emacs docs write for return. So maybe: > > Pedro> --Type for more, q to quit, c to continue without paging-- # 64 cols > > Though I guess I would tend to add a couple of spaces, so: > > -- Type for more, q to quit, c to continue without paging -- # 66 cols That's fine with me. I suspect that the "---" wrapping without spaces might have been inspired by some Unix /usr/bin/more implementation, because util-linux's 'more' prints "--More-- " by default. > I would like to get the spelling worked out before updating the patch. > > Pedro> Did you look up the patch submission, see if it still makes sense? > > Nope, but if we shorten the text then perhaps the change won't be > needed. A racy test won't usually be an issue with size of the text, but about how the regexps might match differently depending on how much the expect buffer happens to get filled with. I found the original submission, here: https://sourceware.org/ml/gdb-patches/2011-05/msg00150.html which points at: ~~~~~~~~~~~~ However, when using read1(), the "" part matches with this snippet from lib/gdb.exp: "" { send_gdb "\n" perror "Window too small." fail "$message" ... ~~~~~~~~~~~~ However, someone *cough* changed that "" to $pagination_prompt instead: -re "$pagination_prompt" { send_gdb "\n" perror "Window too small." fail "$message" in: commit c3f814a14336b9d395f3abad739592929e2faaa0 Author: Pedro Alves AuthorDate: Fri Jul 25 10:07:38 2014 +0100 Fix paginate-*.exp races so it looks like the split is really no longer necessary. A brief passage about this in the commit log would be nice, so that we have a history link in case we need to revisit. Please confirm that the affected tests pass cleanly with make check-read1, just to make sure. Thanks, Pedro Alves