From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 641753858D39 for ; Mon, 15 Nov 2021 02:52:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 641753858D39 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1AF2q050019519 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 14 Nov 2021 21:52:05 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1AF2q050019519 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 90A1D1E940; Sun, 14 Nov 2021 21:52:00 -0500 (EST) Message-ID: <6b270217-7410-9ae2-cfeb-a05c158704c2@polymtl.ca> Date: Sun, 14 Nov 2021 21:52:00 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] gdb: AC_INIT should be called with package and version arguments Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org, Joel Brobecker References: From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 15 Nov 2021 02:52:00 +0000 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 02:52:10 -0000 On 2021-11-13 23:09, Enze Li via Gdb-patches wrote: > This patch adds package and version parameters to AC_INIT and > regenerates the configure script. Just wondering, is there practical reason to change this other than to "do things right"? I'm not against it, I would just like to know the motivation behind it. > diff --git a/gdb/version.m4 b/gdb/version.m4 > new file mode 100644 > index 00000000000..2fa57f680ef > --- /dev/null > +++ b/gdb/version.m4 > @@ -0,0 +1 @@ > +m4_define([GDB_VERSION], [12.0.50]) > We already have the version number in gdb/version.in. I don't know if we want to hardcode it at two places. At least, this should be coordinated with Joel, responsible for the release process including bumping the version number. Simon