From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85]) by sourceware.org (Postfix) with ESMTPS id E192C3835430 for ; Tue, 9 Feb 2021 14:53:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E192C3835430 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PiA33AkTaEkbRKfKg8bUPL9FdWZFZitFjGCD+/CvN78WGZVJz/cj7Hx7OXT3M7nAn6RsBR6yvrBl5hiOj7gCD7K7pvEqRzLDUvOB7E9l9X/M16iTLsX/akO/kGeyXtMmh6KGwVOLiJyP8urfFoTPlK9fPlqy/QYWfpWleuWWj5etVp7FIKCKbIef0jqGNOk6Gba3ZlpvF1QUvsi8YQzACpd8UFKvNuN6yLGBzu1RFagy2EtigbzxqQuM+Vc3SOPVAakTNMxiZp/daB4QIKpcBKLO45aFO4C2XRRynn55Sits9hXksSvN/AtkRp4TgI8YXPebCyxfqFR0XKPJIom4Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=50YJcgbxZ5cbtXM195c6++bo+I3pDi1LLyjE6ye5msg=; b=bQR7wYiVCTLZ8RNR00aQ5rF0U1OVfzr9DIK+80LLsXJ9v6MEl1nJUXyqG46TNoxNX69aHxz0c3jfuf89akA8CWu7DGMSsYpT6Dw3dkp2FwdpMD3HaLPrLZ08mZ5SB2qnrSHfi2lmJTugfz+CRRTMYrRmYJmT5N5FPym3+1EkodPGKyl9IRrNSlhwEkfA0ShGdGWtY+P21aQJckpl+FyjR7Bf6z6olVyOP5aTZVnylzHjoTeXPTew9ysHweQRK31u8ZKNgoDtbveuUlXIHhBBUVrK08BGG9mhZodPs7oKLQFy2py8KV5MpuB2OJxdOyNsucumH0EuOAbMjrU624JFUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR1201MB2523.namprd12.prod.outlook.com (2603:10b6:3:e8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.30; Tue, 9 Feb 2021 14:53:44 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 14:53:44 +0000 Subject: Re: [PATCH 12/30] Move piece_closure and its support to expr.c To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-13-Zoran.Zaric@amd.com> <87zh0edz3s.fsf@tromey.com> From: Zoran Zaric Message-ID: <6b56dec6-e9e0-a490-76aa-5a03ef0838f8@amd.com> Date: Tue, 9 Feb 2021 14:53:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87zh0edz3s.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:b142:b2da:a877:6c3] X-ClientProxiedBy: AM8P190CA0024.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::29) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:b142:b2da:a877:6c3] (2a00:23c7:5a85:6801:b142:b2da:a877:6c3) by AM8P190CA0024.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Tue, 9 Feb 2021 14:53:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ee487ed2-e118-423b-da64-08d8cd0a7f17 X-MS-TrafficTypeDiagnostic: DM5PR1201MB2523: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FnLh8KkcMBSeDjuhc+1V6IQk+NYP+2ATi3DzTPSf/pNkJQhNxJMNPcym0FiZNqlJpb0PGbOsHmgNUfMeusqZQtank0j2AfreKIzHak3di4HqXJS8rANA7kJpc3VnwewCfPgYZOxInXe3oFalBRO2ZioRmNP1gByqrl2JEj6gR5//9EpBDvNBbBRKHYh1g54JeSvnCPKuCqxN8IbVf4xJ3uVBER6zV4f27ZtAFdb7qihXG+w5WF/OLZkVbWx3RLoCeuiG0DAml02sPHEPoZuUGGogGlpfXHHdJQVi1BIAfay+5XTNPMC5kXNXX1lDTyPEEl4uoxWppUqVfhCNh0GWaFEHIBpgpStj6uv1YIr107l9y4cx3uIyerfWaDNylhcWB/zCtxN2LaB6pS05bZ6TFdSCcF9Jc++uQ8F0o4ae/jOcGVSmiETrlfJnorE3sOv7iccqxgxyyehJwyui4RUIQnRSmJEJsSKAsKjfYdgzt9dSXLE8/9N5ifsLHYNF3uRKo85V8o/+7pXaZUDlwDqrXn3ZDcC9OUtTusIp+ejqBSu6otCKpSVNL5690TcW9pJLftB+9WlFwYO0cT00T7+sLmno1aimv2QvrOuHIN/FxYo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(39860400002)(346002)(136003)(376002)(36756003)(5660300002)(4744005)(478600001)(16526019)(66946007)(66556008)(52116002)(66476007)(186003)(2906002)(2616005)(31686004)(8936002)(86362001)(110136005)(31696002)(6486002)(316002)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eUlSejdKTXkrSUFtbmxtMjVNWlR4WGpiaWgrU0VLcFE5VWxBRk04cWhLRE1B?= =?utf-8?B?MWQ1WjM2Q2J2Z2tYRDFzTTBoNll5TG45MlpoVFZtcTVwdFdZV0ErSUxXMjgx?= =?utf-8?B?eXlEWTdkVmtZOG9hRzd2UkFkZkNuS2VDWW9DdTh3Uk5BOFNROEtsdzQ0L2gx?= =?utf-8?B?WlFnRFZoTGt3clIvK3hOcm1NU1IyRXhNSGtxeDduRm5jNmZqamZoeFF3Mkd1?= =?utf-8?B?OStCZWZlQnI1cEVrWDhMNnFWUkUyQTNyVUlLbHZqKzZJSUFENER4YjQvdlRl?= =?utf-8?B?ZFRJb3FYYmpHTElHUnpXYlA3eFAwS1JGdWdiYUdxN3NCQ1ZGajNsazFCS25p?= =?utf-8?B?eE5nMjZ1WG05dnkvMGorUUJzZ0Y0dWMyWUtWZS96akM5NUVNei9xUkpaQkJF?= =?utf-8?B?NEZqMlQ1NUVBQy9UeFJid3A1N05LTW1QOWNGdTIwL3lDTm4wWlVqU211ZmV1?= =?utf-8?B?bWNBdlRndGRUTzhTd1lCZndRU1c0T2FEMVhJVHlYN2NURHp5VlpiQm1CSysy?= =?utf-8?B?MXFHNlN6WHNPUWI2L0Y1U2hiR2txV3JhLzlIaU9naFM5dC9VaHY2VE1hbVdY?= =?utf-8?B?NWNoYTdjemNCb2dEdDNZelZQOWJnRzRYWFhDSkY2VzRnOHdHUW8vZkxRVnRO?= =?utf-8?B?Yk9Ea1UyU1cydWtSVXVCU3MyblZoYUcvNVBuVHFIWTYxRC90VEt1U3FSdHVu?= =?utf-8?B?QUxIYko2K0FoaW0rd0xaaWJyQTdvUzdnYTVXSnVvODkrYWhSNHBCcm1IZitM?= =?utf-8?B?emhyclJIY1hqcjFCT0l2M0xSZjdSZFBQSHJhNHdKSWhLamtaSUV3czZMWFZ1?= =?utf-8?B?K0RiYThYR2dPUTZyNVVOa3lVV3RORDF1TWJkUElDdForVUhPVExJeGFlM2FM?= =?utf-8?B?ZEhIQ1NhcDFrR2ZlTG94YlFjNDRTbEhLUTRXeGx4RVJZL0Z1bEFQSXNHZC9x?= =?utf-8?B?T29ZbFVUR2kxZXhFVnpqYmJoYlAxTFkzVXNYN09xOU1JN3V6OEYweEJYMUtu?= =?utf-8?B?a3l6SlZDZitpLytUdE1raktuYmlFMENVMUtQeGo2elRnSUZhWVlqbVJMVWhL?= =?utf-8?B?cW9yUmRVTE9YMGZja3RXL1B0NTUyY04rcXpGdDM2NzFmZDFlUEpYSis4RVJn?= =?utf-8?B?ZlBjbXptbHpmam5xeUlyRnJUYmVXK3d2a1FKYXZUQlg0MzFRK2crcmlBdkNJ?= =?utf-8?B?dFZJZkcwdVZhSHRaclFVZDF2ZjhCSUtEdFdMbFdZNmFRTFBYZ1A4Q01RR1NT?= =?utf-8?B?SFNwTzl3V0lEUkdxNEgvMmRwM2pWdmtVVWVQU1RjWHNYNFMvOVhqU24xc200?= =?utf-8?B?d2d4d1c2bjV2aFpiUEZyL0h6bnZyYXk2c0hJdlZsSWRZNW9TNnVMdzNsVUc4?= =?utf-8?B?bjBEUFNuUFFVblRYMm9TbVlLZnl3di80aUpUd2FLMDh0SWRQZzg5NjV3cE16?= =?utf-8?B?MS9OQmVRbUpIMkgyQkVtRE1HWlhZSWZSZ1VGZmRaZDI0TGx5SVRkK1ZuMHp6?= =?utf-8?B?V05SV082ckY3UmxCb2YyR2J1aDJKOWduMUwyZ1AwaGlhdTFSaklYd2tWbEhx?= =?utf-8?B?a09yWFgvWEs3K21nOTcyMUZtZnA1NmtpZzNoay85cmlVaFczSC9qVSt4NDVQ?= =?utf-8?B?RWw1c2h5RjRuZ3R0ZkpOTHQ1MnBKaFc1L0ZUMXJsaVhZUWtrZ2ZjSS9lcHhW?= =?utf-8?B?UnFRNE5sQy8vUTM0elhCYkhEZ0NkM0JMeHZJcDZ3NlhwTEh2cHY4QTFSVU9J?= =?utf-8?B?ampCNDhMcWQ2MWppZUE0ZFpCN2U4Vm1qRFFLZXNRTGhKeGFUbGlpWEpDR2VG?= =?utf-8?B?L1NrSDVzWmtuY0pmSUgwdS9ndFZ0NHIydG0wc3Y0Q3dMS3VvYlJ4UEJIakk4?= =?utf-8?Q?nN4GkPVfr5L/J?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee487ed2-e118-423b-da64-08d8cd0a7f17 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 14:53:44.4648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pD467akVEVSZxl2vVHLsPlQ8+AY5XPM/FtcKdwKXF4RUoFRFNjQiXt443Ol5nLLJ4Ht71pUMy0visV3wSMUYmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2523 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 14:53:47 -0000 > > Zoran> * dwarf2/loc.h (invalid_synthetic_pointer): Expose function. > > I didn't understand the need for this change. > This function doesn't seem to be referenced elsewhere in the patch. > > Maybe it's needed for some subsequent change? > > Tom > Thank you Tom. Somehow I missed that and it is used in the later patches. I will make sure to move it to appropriate patch in the next version. Zoran