From: Luis Machado <lgustavo@codesourcery.com>
To: John Baldwin <jhb@freebsd.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] PR threads/20743: Don't attempt to suspend or resume exited threads.
Date: Mon, 17 Apr 2017 18:32:00 -0000 [thread overview]
Message-ID: <6b79429a-d7a5-4355-01e5-61f55fc84669@codesourcery.com> (raw)
In-Reply-To: <14140503.xzYTI4WuLb@ralph.baldwin.cx>
On 04/17/2017 01:27 PM, John Baldwin wrote:
> On Friday, April 14, 2017 08:01:25 PM Luis Machado wrote:
>> On 04/14/2017 05:40 PM, John Baldwin wrote:
>>>> Otherwise i have no further comments. I assume you ran gdb's testsuite
>>>> against this change and verified the results are sane?
>>>
>>> There were no regressions at least. With the stock tree there are
>>> several unexpected failures already which I will get to at some point.
>>>
>>
>> Great. I have no further comments.
>
> To be clear (since I believe I messed this up before), I still need approval
> from an approver?
>
Right. I'm mainly reviewing. I can't formally approve.
next prev parent reply other threads:[~2017-04-17 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 17:33 John Baldwin
2017-04-11 18:43 ` John Baldwin
2017-04-12 18:12 ` Luis Machado
2017-04-14 22:40 ` John Baldwin
2017-04-15 1:01 ` Luis Machado
2017-04-17 18:27 ` John Baldwin
2017-04-17 18:32 ` Luis Machado [this message]
2017-04-18 14:27 ` Simon Marchi
2017-04-18 14:29 ` Simon Marchi
2017-04-18 14:58 ` Pedro Alves
2017-04-18 16:53 ` John Baldwin
2017-04-18 11:33 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b79429a-d7a5-4355-01e5-61f55fc84669@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).