From: Keith Seitz <keiths@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: GDB 8.1.1 release, 2018-05-30 update
Date: Mon, 04 Jun 2018 21:34:00 -0000 [thread overview]
Message-ID: <6b81ad5a-0195-58e9-083c-535c505acb0c@redhat.com> (raw)
In-Reply-To: <20180604211800.h7nh2nifhuauberg@adacore.com>
On 06/04/2018 02:18 PM, Joel Brobecker wrote:
>
> Sorry to hear that. Hope you're better now!
>
Some sort of 24-hour bug. Thank you for your well-wishes.
>> I'm still trying to write a reproducer. It's just really, really elusive.
>
> Do you think we have reached the point where we might be past
> what's reasonable for trying to create a regression test? Just
> trying to guage a bit whether it's worth pouring more resources
> into trying to get one, vs using the resources elsewhere.
Yeah, I've pretty much given up on triggering the exact conditions that cause a user-visible manifestation of this bug. I have a dwarf assembler file that I've been hacking at, and it is getting *quite* large. Still no luck in causing this bug to trigger.
However, I have been thinking about an alternative, easier way to trigger the bug. That is by wrapping add_symbol_to_list in dwarf2read.c with a custom version that checks if we are adding symbols to a language_minimal dictionary. If it sees that, it issues a complaint. [Or add another option to turn this on/off.]
Once again that adds complexity into an already performance-sensitive area, and I'm not really sure it is worth the effort anymore. Not to mention how hacky it is!
So really, I can continue down this road, or maintainers can make the call to omit a test case for it entirely. Otherwise, I'll return my attention to helping with the patch review backlog.
Keith
next prev parent reply other threads:[~2018-06-04 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 22:53 Joel Brobecker
2018-06-01 16:37 ` Keith Seitz
2018-06-04 21:18 ` Joel Brobecker
2018-06-04 21:34 ` Keith Seitz [this message]
2018-06-04 21:57 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b81ad5a-0195-58e9-083c-535c505acb0c@redhat.com \
--to=keiths@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).