From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, jimw@sifive.com, palmer@sifive.com,
jhb@FreeBSD.org
Subject: Re: [PATCH 3/4] gdb/riscv: Create each unique target description only once
Date: Fri, 30 Nov 2018 17:07:00 -0000 [thread overview]
Message-ID: <6babd3ce-36a9-5d55-a471-592a55878dce@redhat.com> (raw)
In-Reply-To: <20181129223227.GI18841@embecosm.com>
On 11/29/2018 10:32 PM, Andrew Burgess wrote:
> +/* Wrapper used by std::unordered_map to generate hash for feature set. */
> +struct riscv_gdbarch_features_hasher
> +{
> + std::size_t
> + operator() (struct riscv_gdbarch_features const& features) const noexcept
I don't think we do "east const" in gdb.
Also, '&' is formatted like '*'.
Might as well drop the "struct" while at it (I'd do that in a number
of places).
That leaves:
operator() (const riscv_gdbarch_features &features) const noexcept
Otherwise looks fine. Thanks!
Pedro Alves
next prev parent reply other threads:[~2018-11-30 17:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 22:50 [RFC] gdb/riscv: Add read_description method for riscv_linux_nat_target Andrew Burgess
2018-11-28 23:37 ` Jim Wilson
2018-11-29 2:23 ` Jim Wilson
2018-11-29 16:50 ` [PATCH 3/4] gdb/riscv: Create each unique target description only once Andrew Burgess
2018-11-29 18:12 ` Pedro Alves
2018-11-29 19:17 ` Andrew Burgess
2018-11-29 22:32 ` Andrew Burgess
2018-11-30 17:07 ` Pedro Alves [this message]
2018-11-29 16:50 ` [PATCH 2/4] gdb/riscv: Add equality operators to riscv_gdb_features Andrew Burgess
2018-11-29 16:50 ` [PATCH 0/4] Re: gdb/riscv: Add read_description method for riscv_linux_nat_target Andrew Burgess
2018-11-29 16:50 ` [PATCH 1/4] gdb/riscv: Make some target description functions constant Andrew Burgess
2018-11-29 16:50 ` [PATCH 4/4] gdb/riscv: Add read_description method for riscv_linux_nat_target Andrew Burgess
2018-11-29 22:22 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6babd3ce-36a9-5d55-a471-592a55878dce@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).