From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26948 invoked by alias); 13 Feb 2020 20:29:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26939 invoked by uid 89); 13 Feb 2020 20:29:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 20:29:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581625781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ImjQ2WBQW8pLCVBzz+zhDoVH42HMH5Uooc/CDNLTxfE=; b=IESoHwQ59+9ow6k03GDX82wiBnc6GcGhGVZkPWXWX+V+XMLY3lfvn/wWnWYpCjqWQV00Yf HJi/zKPGt2K89yBy6s+M+vCk6axNDVG3OpfH24Ze9AGJWQoSW9ql6HqTtlzWYWuf5vo5hG Rn+ba5xXdIko4mI6ODoq4/hl/MzTEGQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-FhJR00U2PHSIjLPd_FQy5w-1; Thu, 13 Feb 2020 15:29:39 -0500 Received: by mail-wr1-f72.google.com with SMTP id a12so2877764wrn.19 for ; Thu, 13 Feb 2020 12:29:39 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id w13sm4355311wru.38.2020.02.13.12.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2020 12:29:37 -0800 (PST) Subject: Re: [PATCH 52/58] gdbserver: turn breakpoint kind-related target ops into methods To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <5f07daabec3126a60bf48b20fd60594bc68c83f0.1581410935.git.tankut.baris.aktemur@intel.com> From: Pedro Alves Message-ID: <6be281b6-aeba-22d9-2121-205fdfb432d9@redhat.com> Date: Thu, 13 Feb 2020 20:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <5f07daabec3126a60bf48b20fd60594bc68c83f0.1581410935.git.tankut.baris.aktemur@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00532.txt.bz2 On 2/11/20 9:02 AM, Tankut Baris Aktemur wrote: > +const gdb_byte * > +lynx_process_target::sw_breakpoint_from_kind (int kind, int *size) > +{ > + error (_("Target does not implement the sw_breakpoint_from_kind op")); > + return nullptr; The return statement is unreachable. Thanks, Pedro Alves