From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7EC9338555A8 for ; Mon, 17 Apr 2023 13:41:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EC9338555A8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681738864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sEbNOcwmusrewhpfVdiaFEEJYbKz8W6BB+Gj4Mbc8T4=; b=V/xZTcxYeNWfpW3WylQ+3++FTrB0hR/IMdGcmHVtWTOYX8SSyXXnqYsSk+G5/JhrT9BbzW NslCBOd2TsT+74LBBydXK/66yrjjmp8x2Cqjwxlu1P+lelvFg2vGVjNxbk0N7F3IG4FKVo 7abP7OlEGqQ7sVhgKcNxhVEA4+pSyu0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-zbGY0RUzPfm2cEplNm2R3g-1; Mon, 17 Apr 2023 09:41:03 -0400 X-MC-Unique: zbGY0RUzPfm2cEplNm2R3g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f080f53d62so4875825e9.0 for ; Mon, 17 Apr 2023 06:41:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681738861; x=1684330861; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sEbNOcwmusrewhpfVdiaFEEJYbKz8W6BB+Gj4Mbc8T4=; b=EHMgzvi3nm7o3lQo4PPgKv1CYVDMYxTXIDFl7PGHGEKECBHw3UE+ys5HfMOrszmixF NEDvE1vk+SUX/8lVXe8t7QkspFElA0krMENQ6SfZGwUQMx1n1PNGUEh3jgmS4LW6uGio O802ewh7Mz18EyvC2f1aNzp5T9IuFZp0Pb8z9vYjMCaO6i+jA+gWBvlZz4WZ4drsBG/L Jyg0wORc3JEuX0nJb/5r49dR1mVO+AtONXSASZvzB7HBrYcuXG7ZXaFHFc1YQlKpcS8j lUg8YeEt0o02r/UEPT6KWbLG2H9sRU7kwwIoQlLgOozerPElLm4/KO2Porc3e99TDSFl fkTw== X-Gm-Message-State: AAQBX9dT3iISPz57VkTDCOWP2C9q+VsDBTeRt6cIgTWy21bDKKbAygrY ovFQVzX60HV/NblU53b5oXZ7yiOQFNNHAPxB/sd2O4jhcHPtYgaMItbJTKzg1/9ci+qzhA69pJB jq4FvWgQGfqkzApKTrwrJpwccFBr53g== X-Received: by 2002:a5d:63cd:0:b0:2f6:8834:5952 with SMTP id c13-20020a5d63cd000000b002f688345952mr5206089wrw.8.1681738861686; Mon, 17 Apr 2023 06:41:01 -0700 (PDT) X-Google-Smtp-Source: AKy350byo/y8yMyElZIzRDnQ+bt3ix4OsQpfxXZP1gnUlp+/n6icYarjkXlHAFh6YA0ixohLqcTVKA== X-Received: by 2002:a5d:63cd:0:b0:2f6:8834:5952 with SMTP id c13-20020a5d63cd000000b002f688345952mr5206075wrw.8.1681738861387; Mon, 17 Apr 2023 06:41:01 -0700 (PDT) Received: from [192.168.0.45] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c228800b003edef091b17sm11991975wmf.37.2023.04.17.06.41.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 06:41:00 -0700 (PDT) Message-ID: <6c66d257-b1f3-6dfa-7a75-bc74a22af26c@redhat.com> Date: Mon, 17 Apr 2023 15:40:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/1] gdb, infcmd: Support jump command with same line in multiple symtabs To: "Puputti, Matti" , "gdb-patches@sourceware.org" References: <20230414141536.2667798-1-matti.puputti@intel.com> <20230414141536.2667798-2-matti.puputti@intel.com> <6285e3d2-bace-3b55-3dff-6757e5e14427@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17/04/2023 13:33, Puputti, Matti wrote: > Hi Bruno, > > I have just now uploaded third patch, with updated commit message. > https://sourceware.org/pipermail/gdb-patches/2023-April/198912.html > > If you are good with the new patch, may I ask a favour: can you please push it for me? I don't have write access, as this this is my first patch series (potentially) to be approved. Hi Matti, I don't have the authority to actually approve patches for merging, I just review them as a way to signal to the maintainers who can actually approve that it has passed my review and so (hopefully) doesn't contain obvious mistakes, making their lives easier. The tag you'd be looking for is Approved-by. Sorry if this was confusing -- Cheers, Bruno > > Br, > Matti Puputti > >> -----Original Message----- >> From: Bruno Larsen >> Sent: Monday, April 17, 2023 12:17 PM >> To: Puputti, Matti ; gdb-patches@sourceware.org >> Subject: Re: [PATCH v2 1/1] gdb, infcmd: Support jump command with same line >> in multiple symtabs >> >> Hi Matti, >> >> Only some small nits on the commit message: >> >> On 14/04/2023 16:15, Matti Puputti wrote: >>> For example, a header file defining a static function is included in multiple >> Starting with "If a header (...)" makes more sense in my opinion >>> source files, each calling the function. When debugger is asked to jump to >> "When the debugger" or "When GDB" would flow better >>> a line inside that function, there would be multiple locations matching the >>> target. Solution in this commit is to select the location in the current >> "The solution in this commit", as mentioend above >>> symtab. >> With these changes, I'm fine with giving you my tag: >> Reviewed-By: Bruno Larsen >> >> -- >> Cheers, >> Bruno >> > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928